Rollup of 12 pull requests #100947
Closed
Rollup of 12 pull requests #100947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
High traffic macros should detail this helpful addition.
… indexing The error can be quite confusing to newcomers.
...replacing `.cast().wrapping_offset().cast()` & similar code.
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Rootless podman creates a separate user namespace, where an inner `LOCAL_USER_ID` will map to a different subuid range on the host. The "keep-id" mode maps the current UID directly into the container. This makes `src/ci/docker/run.sh` work better for testing container images on systems running podman, where "docker" is just a shim.
According to [blame], this rule was added to support enum struct variants. However, enum struct variants don't use tables in their design any more, so this rule does nothing. [blame]: https://github.com/rust-lang/rust/blame/87991d5f5d72d6baca490141cb890211ba2f3843/src/librustdoc/html/static/css/rustdoc.css#L748
…riplett Properly forward `ByRefSized::fold` to the inner iterator cc ```@timvermeulen,``` who noticed this mistake in rust-lang#100214 (comment)
Fix wrong compiletest filters on Windows As discussed in [rust-lang#79334](rust-lang#79334), when calling e.g. ``` python x.py test src/test/ui/expr/compound-assignment/eval-order.rs ``` on Windows, compiletest passes the filter `expr/compound-assignment/eval-order.rs` to libtest, which instead should be `expr\compound-assignment\eval-order.rs`, as that is the file found when collecting tests. This is what I fixed. I'm not sure how to organize a test for this. Any suggestions?
… r=scottmcm
Make use of `[wrapping_]byte_{add,sub}`
These new methods trivially replace old `.cast().wrapping_offset().cast()` & similar code.
Note that [`arith_offset`](https://doc.rust-lang.org/std/intrinsics/fn.arith_offset.html) and `wrapping_offset` are the same thing.
r? ```@scottmcm```
_split off from #100746_
…with_positional_arg, r=TaKO8Ki sugg: take into count the debug formatting Closes rust-lang#100648 This PR will fix a suggestion error by taking into consideration also the `:?` symbol and act in a different way `@rustbot` r? `@compiler-errors` N.B: I did not find a full way to test the change, any idea?
Extra documentation for new formatting feature Documentation of this feature was added in rust-lang#90473 and released in Rust 1.58. However, high traffic macros did not receive new examples. Namely `println!()` and `format!()`. The doc comments included in Rust are super important to the community- especially newcomers. I have met several other newbies like myself who are unaware of this recent (well about 7 months old now) update to the language allowing for convenient intra-string identifiers. Bringing small examples of this feature to the doc comments of `println!()` and `format!()` would be helpful to everyone learning the language. [Blog Post Announcing Feature](https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html) [Feature PR](rust-lang#90473) - includes several instances of documentation of the feature- minus the macros in question for this PR *This is my first time contributing to a project this large. Feedback would mean the world to me 😄* --- *Recreated; I violated the [No-Merge Policy](https://rustc-dev-guide.rust-lang.org/git.html#no-merge-policy)*
… r=sanxiyn Make some methods private
…avidtwco Suggest alternatives when trying to mutate a `HashMap`/`BTreeMap` via indexing The error can be quite confusing to newcomers. Fixes rust-lang#100873. I'm not so sure about the message, open to wording suggestions.
Diagnose missing includes in run-make tests
…, r=notriddle Rewrite error index generator to greatly reduce the size of the pages Fixes rust-lang#100736. Instead of having all error codes in a same page (making the DOM way too big), I split the output into multiple files and generated a list of links (if there is an explanation) to the error codes' explanation into the already existing file. I also used this opportunity to greatly simplify the code. Instead of needing a `build.rs`, I simply imported the file we want and wrote the macro which generates a function containing everything we need. We just need to call it to get the error codes and their explanation (if any). Also, considering the implementations between markdown and HTML formats differed even further, the `Formatter` trait was becoming too problematic so I removed it too. You can test it [here](https://rustdoc.crud.net/imperio/rewrite-error-index/error-index.html). cc `@jsha` r? `@notriddle`
Use `--userns=keep-id` when "docker" is really podman Rootless podman creates a separate user namespace, where an inner `LOCAL_USER_ID` will map to a different subuid range on the host. The "keep-id" mode maps the current UID directly into the container. This makes `src/ci/docker/run.sh` work better for testing container images on systems running podman, where "docker" is just a shim.
…r=sanxiyn rustdoc: remove unused CSS rule According to [blame], this rule was added to support enum struct variants. However, enum struct variants don't use tables in their design any more, so this rule does nothing. [blame]: https://github.com/rust-lang/rust/blame/87991d5f5d72d6baca490141cb890211ba2f3843/src/librustdoc/html/static/css/rustdoc.css#L748
…impl-generic-mismatch, r=Dylan-DPC Add a missing test case for impl generic mismatch This suggestion use different span depending on whether the method has generics or not, so I added a test case about the method with some generics.
rustbot
added
T-bootstrap
rustbot
added
T-rustdoc
|
@bors r+ rollup=never p=12 |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 62ae1fa with merge 2cdc5baca81e34ae0868f9aa5437da5552895787... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry timeout |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 62ae1fa with merge 1f0aed84e44198f1810ea5db6431e78a7c174bfe... |
|
Hmm, it might be that there is a miri test that somehow gets stuck (its always the x86 and msvcs tool builders that are hanging) but I didn't see and clear indication which test it might be :/ |
This was referenced Aug 24, 2022
Would be good to ping @rust-lang/miri in such situations. I just spent 15min tracking down a strange Miri hang, until narrowing it down to #101152. |
|
Actually turns out this was a real bug that our test suite missed but the Miri test suite caught -- see #101235. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ByRefSized::foldto the inner iterator #100220 (Properly forwardByRefSized::foldto the inner iterator)[wrapping_]byte_{add,sub}#100819 (Make use of[wrapping_]byte_{add,sub})HashMap/BTreeMapvia indexing #100906 (Suggest alternatives when trying to mutate aHashMap/BTreeMapvia indexing)--userns=keep-idwhen "docker" is really podman #100930 (Use--userns=keep-idwhen "docker" is really podman)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup