Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: ayu code color selector more specific #100960

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Aug 24, 2022

According to #100960 (comment), this selector is only really intended to apply to item info. However, it's so broad that it's hard to tell when it deliberately applies vs where it accidentally applies.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 24, 2022
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2022

A change occurred in the Ayu theme.

cc @Cldfire

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @CraftSpider

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2022
@GuillaumeGomez
Copy link
Member

Sorry, I misunderstood what you meant. This rule specifically is for item information, not search results.

According to #100960 (comment),
this selector is only really intended to apply to item info. However,
it's so broad that it's hard to tell when it deliberately applies vs where it
accidentally applies.
@notriddle notriddle force-pushed the notriddle/ayu-span-code branch from 30e2995 to 5bac3d7 Compare August 24, 2022 17:41
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Aug 24, 2022

📌 Commit 5bac3d7 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2022
@GuillaumeGomez
Copy link
Member

@bors rollup

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 24, 2022
… r=GuillaumeGomez

rustdoc: ayu code color selector more specific

According to rust-lang#100960 (comment), this selector is only really intended to apply to item info. However, it's so broad that it's hard to tell when it deliberately applies vs where it accidentally applies.
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#99332 (Stabilize `#![feature(label_break_value)]`)
 - rust-lang#99954 (let-else: break out to one scope higher for let-else)
 - rust-lang#100188 (Parser will not suggest invalid expression when use public)
 - rust-lang#100780 (save_analysis: Migrate diagnostic)
 - rust-lang#100808 (Migrate `rustc_interface` diagnostics )
 - rust-lang#100921 (Add a warning about `Option/Result::and()` being eagerly evaluated)
 - rust-lang#100960 (rustdoc: ayu code color selector more specific)
 - rust-lang#100964 (Sync rustc_codegen_cranelift)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1e1dc7b into master Aug 25, 2022
@bors bors deleted the notriddle/ayu-span-code branch August 25, 2022 05:13
@rustbot rustbot added this to the 1.65.0 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants