Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #100963

Merged
merged 36 commits into from
Aug 24, 2022
Merged

Rollup of 15 pull requests #100963

merged 36 commits into from
Aug 24, 2022

Commits on Jul 31, 2022

  1. Configuration menu
    Copy the full SHA
    04a7fef View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Configuration menu
    Copy the full SHA
    7680c8b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2022

  1. Extra documentation for new formatting feature

    High traffic macros should detail this helpful addition.
    IsaacCloos committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    acca4b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. make some methods private

    TaKO8Ki committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    000dc80 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Configuration menu
    Copy the full SHA
    ba74a62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f280138 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5ff45dc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ac0b6af View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4cb492e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4da14ef View commit details
    Browse the repository at this point in the history
  7. Suggest alternatives when trying to mutate a HashMap/BTreeMap via…

    … indexing
    
    The error can be quite confusing to newcomers.
    ChayimFriedman2 committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    b0255a1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8ad36c4 View commit details
    Browse the repository at this point in the history
  9. Update README.md

    tusharxoxoxo authored Aug 23, 2022
    Configuration menu
    Copy the full SHA
    9397b6c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c664a36 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4398d92 View commit details
    Browse the repository at this point in the history
  12. sugg: take into count the debug formatting

    Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
    vincenzopalazzo committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    3d8c7d2 View commit details
    Browse the repository at this point in the history
  13. Use --userns=keep-id when "docker" is really podman

    Rootless podman creates a separate user namespace, where an inner
    `LOCAL_USER_ID` will map to a different subuid range on the host.
    The "keep-id" mode maps the current UID directly into the container.
    
    This makes `src/ci/docker/run.sh` work better for testing container
    images on systems running podman, where "docker" is just a shim.
    cuviper committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    4eb748b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. rustdoc: remove unused CSS rule

    According to [blame], this rule was added to support enum struct
    variants. However, enum struct variants don't use tables in their design
    any more, so this rule does nothing.
    
    [blame]: https://github.com/rust-lang/rust/blame/87991d5f5d72d6baca490141cb890211ba2f3843/src/librustdoc/html/static/css/rustdoc.css#L748
    notriddle committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    b1925b8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3855e03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    56f9e29 View commit details
    Browse the repository at this point in the history
  4. use a minimized example

    TaKO8Ki committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    c57ecfa View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#99993 - petrochenkov:linkdated, r=bjorn3

    linker: Update some outdated comments
    
    r? ``@bjorn3``
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    bc05045 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#100220 - scottmcm:fix-by-ref-sized, r=josht…

    …riplett
    
    Properly forward `ByRefSized::fold` to the inner iterator
    
    cc ``@timvermeulen,`` who noticed this mistake in rust-lang#100214 (comment)
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    6deca5f View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#100826 - vincenzopalazzo:macros/wrong_sugg_…

    …with_positional_arg, r=TaKO8Ki
    
    sugg: take into count the debug formatting
    
    Closes rust-lang#100648
    
    This PR will fix a suggestion error by taking into consideration also the `:?` symbol and act in a different way
    
    ``@rustbot`` r? ``@compiler-errors``
    
    N.B: I did not find a full way to test the change, any idea?
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    f8e128f View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#100855 - IsaacCloos:master, r=joshtriplett

    Extra documentation for new formatting feature
    
    Documentation of this feature was added in rust-lang#90473 and released in Rust 1.58. However, high traffic macros did not receive new examples. Namely `println!()` and `format!()`.
    
    The doc comments included in Rust are super important to the community- especially newcomers. I have met several other newbies like myself who are unaware of this recent (well about 7 months old now) update to the language allowing for convenient intra-string identifiers.
    
    Bringing small examples of this feature to the doc comments of `println!()` and `format!()` would be helpful to everyone learning the language.
    
    [Blog Post Announcing Feature](https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html)
    [Feature PR](rust-lang#90473) - includes several instances of documentation of the feature- minus the macros in question for this PR
    
    *This is my first time contributing to a project this large. Feedback would mean the world to me 😄*
    
    ---
    
    *Recreated; I violated the [No-Merge Policy](https://rustc-dev-guide.rust-lang.org/git.html#no-merge-policy)*
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e802df9 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#100888 - spastorino:coherence-negative-impl…

    …s-implied-bounds, r=lcnr
    
    Coherence negative impls implied bounds
    
    Fixes rust-lang#93875
    
    This PR is rebased on top of rust-lang#100789 and it would need to include that one which is already r+ed.
    
    r? ``@nikomatsakis``
    
    cc ``@lcnr`` (which I've talked about rust-lang@3222f42, I guess after you finish your reordering of modules and work with OutlivesEnvironmentEnv this commit can just be reverted).
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    0fcabec View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#100901 - TaKO8Ki:make-some-methods-private,…

    … r=sanxiyn
    
    Make some methods private
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    1c0f60f View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#100906 - ChayimFriedman2:map-index-mut, r=d…

    …avidtwco
    
    Suggest alternatives when trying to mutate a `HashMap`/`BTreeMap` via indexing
    
    The error can be quite confusing to newcomers.
    
    Fixes rust-lang#100873.
    
    I'm not so sure about the message, open to wording suggestions.
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    95135be View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#100912 - tmiasko:make-include, r=TaKO8Ki

    Diagnose missing includes in run-make tests
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    ecf14d4 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#100919 - sanxiyn:parallel-liveness, r=oli-obk

    Use par_body_owners for liveness
    
    I did this refactoring while working on something else. Liveness is about bodies, there is no reason to use par_for_each_module here.
    
    Tests are updated because things are visited in a different order. I checked diagnostics are same, just in a different (and IMO, better) order.
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    8cdf408 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#100922 - GuillaumeGomez:rewrite-error-index…

    …, r=notriddle
    
    Rewrite error index generator to greatly reduce the size of the pages
    
    Fixes rust-lang#100736.
    
    Instead of having all error codes in a same page (making the DOM way too big), I split the output into multiple files and generated a list of links (if there is an explanation) to the error codes' explanation into the already existing file.
    
    I also used this opportunity to greatly simplify the code. Instead of needing a `build.rs`, I simply imported the file we want and wrote the macro which generates a function containing everything we need. We just need to call it to get the error codes and their explanation (if any). Also, considering the implementations between markdown and HTML formats differed even further, the `Formatter` trait was becoming too problematic so I removed it too.
    
    You can test it [here](https://rustdoc.crud.net/imperio/rewrite-error-index/error-index.html).
    
    cc ``@jsha``
    r? ``@notriddle``
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    fe1f1f1 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#100926 - tusharxoxoxo:master, r=Dylan-DPC

    Update README.md
    
    Fixed Small grammatical Errors
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    234a1cc View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#100930 - cuviper:podman-keep-id, r=jyn514

    Use `--userns=keep-id` when "docker" is really podman
    
    Rootless podman creates a separate user namespace, where an inner
    `LOCAL_USER_ID` will map to a different subuid range on the host.
    The "keep-id" mode maps the current UID directly into the container.
    
    This makes `src/ci/docker/run.sh` work better for testing container
    images on systems running podman, where "docker" is just a shim.
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    a81012c View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#100938 - notriddle:notriddle/fields-table, …

    …r=sanxiyn
    
    rustdoc: remove unused CSS rule
    
    According to [blame], this rule was added to support enum struct variants. However, enum struct variants don't use tables in their design any more, so this rule does nothing.
    
    [blame]: https://github.com/rust-lang/rust/blame/87991d5f5d72d6baca490141cb890211ba2f3843/src/librustdoc/html/static/css/rustdoc.css#L748
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    a0fbfd8 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#100940 - TaKO8Ki:do-not-suggest-adding-boun…

    …d-to-opaque-type, r=fee1-dead
    
    Do not suggest adding a bound to a opaque type
    
    fixes rust-lang#100442
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    75b1b69 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#100945 - TaKO8Ki:add-missing-test-case-for-…

    …impl-generic-mismatch, r=Dylan-DPC
    
    Add a missing test case for impl generic mismatch
    
    This suggestion use different span depending on whether the method has generics or not, so I added a test case about the method with some generics.
    matthiaskrgr authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    fb88e25 View commit details
    Browse the repository at this point in the history