-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate rustc_lint
lint diagnostics
#101138
Migrate rustc_lint
lint diagnostics
#101138
Conversation
@rustbot label: +A-diagnostics |
47cf0c8
to
8d6c390
Compare
@davidtwco How would I untangle |
This comment has been minimized.
This comment has been minimized.
859887d
to
6181790
Compare
I think |
2d6a3c6
to
e5be009
Compare
@davidtwco Same thing for |
3fab63e
to
ba2f365
Compare
@davidtwco How would I migrate usages of |
We have
I think so, yeah. |
@davidtwco There's no |
b9d1e5c
to
00e4d6d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
6f4f315
to
a3c0081
Compare
What diagnostic are you trying to migrate where this is necessary? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, thanks for your continued work on this.
@davidtwco Mostly the diagnostics in |
@davidtwco Also, should I make a new PR for refactoring the diagnostic structs in |
0ea6b44
to
1f0b080
Compare
1f0b080
to
88e5dd2
Compare
@bors r+ |
⌛ Testing commit 88e5dd2 with merge c62631d39f8d2ecafc2bf57779be6bc835c116fd... |
💔 Test failed - checks-actions |
This comment was marked as resolved.
This comment was marked as resolved.
☀️ Test successful - checks-actions |
Finished benchmarking commit (bfffe40): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Part 2 of Migrate
rustc_lint
errors toSessionDiagnostic
r? @davidtwco
TODO
DecorateLint
to useOption<Subdiagnostic>
.#[rustc_lint_diagnostics]
to lint functions incontext.rs
.hidden_unicode_codepoints.rs
.UnsafeCode
inbuiltin.rs
.builtin.rs
.