-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #101233
Rollup of 6 pull requests #101233
Commits on Aug 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 137f20c - Browse repository at this point
Copy the full SHA 137f20cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40f4473 - Browse repository at this point
Copy the full SHA 40f4473View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33cbbc2 - Browse repository at this point
Copy the full SHA 33cbbc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e914247 - Browse repository at this point
Copy the full SHA e914247View commit details -
allow non-monomorphize modules to access hard-coded error message thr…
…ough new struct, use fluent message in monomorphize
Configuration menu - View commit details
-
Copy full SHA for 30c7506 - Browse repository at this point
Copy the full SHA 30c7506View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cdfdd0 - Browse repository at this point
Copy the full SHA 6cdfdd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82d609c - Browse repository at this point
Copy the full SHA 82d609cView commit details
Commits on Aug 26, 2022
-
translations(rustc_session): migrate the file cgu_reuse_tracker
This commit migrates the errors that indicates an incorrect CGU type and the fatal error that indicates that a CGU has not been correctly recorded
Configuration menu - View commit details
-
Copy full SHA for 706452e - Browse repository at this point
Copy the full SHA 706452eView commit details -
translations(rustc_session): migrate 80% of the file parse.rs
This commit migrates around 80% of the parse file to use SsessionDiagnostic We still have to migrate struct_err and struct_warn.
Configuration menu - View commit details
-
Copy full SHA for d5262a9 - Browse repository at this point
Copy the full SHA d5262a9View commit details -
translations(rustc_session): migrate check_expected_reuse
This commit migrates the errors in the function check_expected_reuse to use the new SessionDiagnostic. It also does some small refactor for the IncorrectCguReuseType to include the 'at least' word in the fluent translation file
Configuration menu - View commit details
-
Copy full SHA for 2c77f3e - Browse repository at this point
Copy the full SHA 2c77f3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a19139f - Browse repository at this point
Copy the full SHA a19139fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 845d567 - Browse repository at this point
Copy the full SHA 845d567View commit details
Commits on Aug 30, 2022
-
rustdoc: Resugar async fn return type in
clean
, nothtml
This way it also happens for json output. Fixes rust-lang#101199
Configuration menu - View commit details
-
Copy full SHA for 6099d17 - Browse repository at this point
Copy the full SHA 6099d17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c585fc - Browse repository at this point
Copy the full SHA 6c585fcView commit details -
ADD - InvalidSymbolName to migrate symbol-name({}) error to new diagn…
…ostics infraestructure ADD - dependencies needed to port a module to new Diagnostics infra (rustc_macros, rustc_errors, errors file, and fluent file)
Configuration menu - View commit details
-
Copy full SHA for 86f8c4e - Browse repository at this point
Copy the full SHA 86f8c4eView commit details -
ADD - migrate InvalidTraitItem and AltInvalidTraitItem errors
Thought of doing this by having a struct and an enum with Default and Alt cases, but not sure if we wanted to have the text in code instead of having “demangling()” and “demangling-alt()” in the ftl file. Don’t like the current way of having structs representing the same-ish and using long names to distinguish their expectations, instead of putting this in an enum and handling the different cases inside the type. I am fine with whichever option the team prefers; also understand having them as separate structs keeps it simple.
Configuration menu - View commit details
-
Copy full SHA for 359002b - Browse repository at this point
Copy the full SHA 359002bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd83bbc - Browse repository at this point
Copy the full SHA bd83bbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f5fada - Browse repository at this point
Copy the full SHA 8f5fadaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef2f6ab - Browse repository at this point
Copy the full SHA ef2f6abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ee6946 - Browse repository at this point
Copy the full SHA 3ee6946View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8588374 - Browse repository at this point
Copy the full SHA 8588374View commit details
Commits on Aug 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 900cda2 - Browse repository at this point
Copy the full SHA 900cda2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 477b7ba - Browse repository at this point
Copy the full SHA 477b7baView commit details -
Rollup merge of rust-lang#90946 - GuillaumeGomez:def-id-remove-weird-…
…case, r=Manishearth Ignore `reference`s in "Type::inner_def_id" Fixes rust-lang#90775. Reopening of rust-lang#90726. As discussed on [zulip](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/rendering.20for.20reference.20primitive.20doc.20page), the reference page shouldn't list these implementations (since they are listed on the types and on the traits in any case). And more generally, you don't implement something on a reference but on something behind a reference. I think it's the important point. So currently it looks like this: ![Screenshot from 2021-11-16 10-20-41](https://user-images.githubusercontent.com/3050060/141957799-57aeadc5-41f8-45f6-a4a5-33b1eca6a500.png) With this PR, only the implementations over generics behind a reference are kept. You can test it [here](https://rustdoc.crud.net/imperio/def-id-remove-weird-case/std/primitive.reference.html). cc `@camelid`
Configuration menu - View commit details
-
Copy full SHA for fcc90f2 - Browse repository at this point
Copy the full SHA fcc90f2View commit details -
Rollup merge of rust-lang#100730 - CleanCut:diagnostics-rustc_monomor…
…phize, r=davidtwco Migrate rustc_monomorphize to use SessionDiagnostic ### Description - Migrates diagnostics in `rustc_monomorphize` to use `SessionDiagnostic` - Adds an `impl IntoDiagnosticArg for PathBuf` ### TODO / Help! - [x] I'm having trouble figuring out how to apply an optional note. 😕 Help!? - Resolved. It was bad docs. Fixed in https://github.com/rust-lang/rustc-dev-guide/pull/1437/files - [x] `errors:RecursionLimit` should be `#[fatal ...]`, but that doesn't exist so it's `#[error ...]` at the moment. - Maybe I can switch after this is merged in? --> rust-lang#100694 - Or maybe I need to manually implement `SessionDiagnostic` instead of deriving it? - [x] How does one go about converting an error inside of [a call to struct_span_lint_hir](https://github.com/rust-lang/rust/blob/8064a495086c2e63c0ef77e8e82fe3b9b5dc535f/compiler/rustc_monomorphize/src/collector.rs#L917-L927)? - [x] ~What placeholder do you use in the fluent template to refer to the value in a vector? It seems like [this code](https://github.com/rust-lang/rust/blob/0b79f758c9aa6646606662a6d623a0752286cd17/compiler/rustc_macros/src/diagnostics/diagnostic_builder.rs#L83-L114) ought to have the answer (or something near it)...but I can't figure it out.~ You can't. Punted.
Configuration menu - View commit details
-
Copy full SHA for ac7705f - Browse repository at this point
Copy the full SHA ac7705fView commit details -
Rollup merge of rust-lang#100753 - LuisCardosoOliveira:translation-mi…
…grate-session, r=davidtwco translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1 ## Description This is the first PR for the migration of the module `rustc_session`. You can follow my progress [here](rust-lang#100717 (comment)). The PR migrates the files `cgu_reuse_tracker` and `parse.rs` to use `SessionDiagnostic `.
Configuration menu - View commit details
-
Copy full SHA for d8f2acf - Browse repository at this point
Copy the full SHA d8f2acfView commit details -
Rollup merge of rust-lang#100831 - JhonnyBillM:migrate-symbol-manglin…
…g-to-diagnostics-structs, r=davidtwco Migrate `symbol_mangling` module to new diagnostics structs
Configuration menu - View commit details
-
Copy full SHA for 7e11c11 - Browse repository at this point
Copy the full SHA 7e11c11View commit details -
Rollup merge of rust-lang#101204 - aDotInTheVoid:async-resugar-in-cle…
…an, r=GuillaumeGomez rustdoc: Resugar async fn return type in `clean`, not `html` This way it also happens for json output. Fixes rust-lang#101199 r? `@GuillaumeGomez`
Configuration menu - View commit details
-
Copy full SHA for 72e33a3 - Browse repository at this point
Copy the full SHA 72e33a3View commit details -
Rollup merge of rust-lang#101216 - ehuss:sanitizer-links, r=JohnTitor
Use in-page links for sanitizer docs. This updates the sanitizer documentation page so that the links in the summary at the top jump to the relevant sections within the page instead of leading away to a different site. I think this makes it a little easier to navigate this page which has gotten quite long. This also fixes the broken link for MemTagSanitizer which was not defined. It also adds MemTagSanitizer to the external summary list at the bottom of the page.
Configuration menu - View commit details
-
Copy full SHA for 39b083c - Browse repository at this point
Copy the full SHA 39b083cView commit details