Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #101233

Closed
wants to merge 29 commits into from

Commits on Aug 25, 2022

  1. Configuration menu
    Copy the full SHA
    137f20c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    40f4473 View commit details
    Browse the repository at this point in the history
  3. remove stray comment

    CleanCut committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    33cbbc2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e914247 View commit details
    Browse the repository at this point in the history
  5. allow non-monomorphize modules to access hard-coded error message thr…

    …ough new struct, use fluent message in monomorphize
    CleanCut committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    30c7506 View commit details
    Browse the repository at this point in the history
  6. adjust to new error value

    CleanCut committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    6cdfdd0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    82d609c View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. translations(rustc_session): migrate the file cgu_reuse_tracker

    This commit migrates the errors that indicates an incorrect
    CGU type and the fatal error that indicates that a CGU has
    not been correctly recorded
    beowolx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    706452e View commit details
    Browse the repository at this point in the history
  2. translations(rustc_session): migrate 80% of the file parse.rs

    This commit migrates around 80% of the parse file to use SsessionDiagnostic
    We still have to migrate struct_err and struct_warn.
    beowolx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    d5262a9 View commit details
    Browse the repository at this point in the history
  3. translations(rustc_session): migrate check_expected_reuse

    This commit migrates the errors in the function check_expected_reuse
    to use the new SessionDiagnostic. It also does some small refactor
    for the IncorrectCguReuseType to include the 'at least' word in the
    fluent translation file
    beowolx committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    2c77f3e View commit details
    Browse the repository at this point in the history
  4. remove unnecessary comment

    CleanCut committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    a19139f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    845d567 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. rustdoc: Resugar async fn return type in clean, not html

    This way it also happens for json output.
    
    Fixes rust-lang#101199
    aDotInTheVoid committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    6099d17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c585fc View commit details
    Browse the repository at this point in the history
  3. ADD - InvalidSymbolName to migrate symbol-name({}) error to new diagn…

    …ostics infraestructure
    
    ADD - dependencies needed to port a module to new Diagnostics infra (rustc_macros, rustc_errors, errors file, and fluent file)
    JhonnyBillM committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    86f8c4e View commit details
    Browse the repository at this point in the history
  4. ADD - migrate InvalidTraitItem and AltInvalidTraitItem errors

    Thought of doing this by having a struct and an enum with Default and Alt cases, but not sure if we wanted to have the text in code instead of having “demangling()” and “demangling-alt()” in the ftl file.
    
    Don’t like the current way of having structs representing the same-ish and using long names to distinguish their expectations, instead of putting this in an enum and handling the different cases inside the type.
    
    I am fine with whichever option the team prefers; also understand having them as separate structs keeps it simple.
    JhonnyBillM committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    359002b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd83bbc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8f5fada View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ef2f6ab View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3ee6946 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8588374 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Configuration menu
    Copy the full SHA
    900cda2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    477b7ba View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#90946 - GuillaumeGomez:def-id-remove-weird-…

    …case, r=Manishearth
    
    Ignore `reference`s in "Type::inner_def_id"
    
    Fixes rust-lang#90775.
    
    Reopening of rust-lang#90726.
    
    As discussed on [zulip](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/rendering.20for.20reference.20primitive.20doc.20page), the reference page shouldn't list these implementations (since they are listed on the types and on the traits in any case). And more generally, you don't implement something on a reference but on something behind a reference. I think it's the important point.
    
    So currently it looks like this:
    
    ![Screenshot from 2021-11-16 10-20-41](https://user-images.githubusercontent.com/3050060/141957799-57aeadc5-41f8-45f6-a4a5-33b1eca6a500.png)
    
    With this PR, only the implementations over generics behind a reference are kept.
    
    You can test it [here](https://rustdoc.crud.net/imperio/def-id-remove-weird-case/std/primitive.reference.html).
    
    cc `@camelid`
    GuillaumeGomez committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    fcc90f2 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#100730 - CleanCut:diagnostics-rustc_monomor…

    …phize, r=davidtwco
    
    Migrate rustc_monomorphize to use SessionDiagnostic
    
    ### Description
    
    - Migrates diagnostics in `rustc_monomorphize` to use `SessionDiagnostic`
    - Adds an `impl IntoDiagnosticArg for PathBuf`
    
    ### TODO / Help!
    - [x] I'm having trouble figuring out how to apply an optional note. 😕  Help!?
      - Resolved. It was bad docs. Fixed in https://github.com/rust-lang/rustc-dev-guide/pull/1437/files
    - [x] `errors:RecursionLimit` should be `#[fatal ...]`, but that doesn't exist so it's `#[error ...]` at the moment.
      - Maybe I can switch after this is merged in? --> rust-lang#100694
      - Or maybe I need to manually implement `SessionDiagnostic` instead of deriving it?
    - [x] How does one go about converting an error inside of [a call to struct_span_lint_hir](https://github.com/rust-lang/rust/blob/8064a495086c2e63c0ef77e8e82fe3b9b5dc535f/compiler/rustc_monomorphize/src/collector.rs#L917-L927)?
    - [x] ~What placeholder do you use in the fluent template to refer to the value in a vector? It seems like [this code](https://github.com/rust-lang/rust/blob/0b79f758c9aa6646606662a6d623a0752286cd17/compiler/rustc_macros/src/diagnostics/diagnostic_builder.rs#L83-L114) ought to have the answer (or something near it)...but I can't figure it out.~ You can't. Punted.
    GuillaumeGomez committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    ac7705f View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#100753 - LuisCardosoOliveira:translation-mi…

    …grate-session, r=davidtwco
    
    translations(rustc_session): migrates `rustc_session` to use `SessionDiagnostic` - Pt. 1
    
    ## Description
    
    This is the first PR for the migration of the module `rustc_session`. You can follow my progress [here](rust-lang#100717 (comment)).
    
    The PR migrates the files `cgu_reuse_tracker` and `parse.rs` to use `SessionDiagnostic `.
    GuillaumeGomez committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d8f2acf View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#100831 - JhonnyBillM:migrate-symbol-manglin…

    …g-to-diagnostics-structs, r=davidtwco
    
    Migrate `symbol_mangling` module to new diagnostics structs
    GuillaumeGomez committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    7e11c11 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#101204 - aDotInTheVoid:async-resugar-in-cle…

    …an, r=GuillaumeGomez
    
    rustdoc: Resugar async fn return type in `clean`, not `html`
    
    This way it also happens for json output.
    
    Fixes rust-lang#101199
    
    r? `@GuillaumeGomez`
    GuillaumeGomez committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    72e33a3 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#101216 - ehuss:sanitizer-links, r=JohnTitor

    Use in-page links for sanitizer docs.
    
    This updates the sanitizer documentation page so that the links in the summary at the top jump to the relevant sections within the page instead of leading away to a different site. I think this makes it a little easier to navigate this page which has gotten quite long.
    
    This also fixes the broken link for MemTagSanitizer which was not defined.  It also adds MemTagSanitizer to the external summary list at the bottom of the page.
    GuillaumeGomez committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    39b083c View commit details
    Browse the repository at this point in the history