Rollup of 6 pull requests #101328
Closed
Rollup of 6 pull requests #101328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the MIR validator used RevealAll in its ParamEnv for type checking. This could cause false negatives in some cases due to RevealAll ParamEnvs not always use all predicates as expected here. Since some MIR passes like inlining use RevealAll as well, keep using it in the MIR validator too, but when it fails usign RevealAll, also try the check without it, to stop false negatives.
Before, it called `normalize_erasing_regions` twice since `equal_up_to_regions` called it as well for both types.
revealed by tests, manually add a panic to test for dead code
…ossible... - ... when creating diagnostics in rustc_metadata - use the error_code! macro - pass macro output to diag.code() - use fluent from within manual implementation of SessionDiagnostic - emit the untested errors in case they occur in the wild - stop panicking in the probably-not-dead code, add fixme to write test
This avoid unnecessarily getting the full reparse data when all we need is the tag.
This fixes rustdoc not showing the current version as stabilization version for recently stabilized lang features.
… r=oli-obk Try normalizing types without RevealAll in ParamEnv in MIR validation Before, the MIR validator used RevealAll in its ParamEnv for type checking. This could cause false negatives in some cases due to RevealAll ParamEnvs not always use all predicates as expected here. Since some MIR passes like inlining use RevealAll as well, keep using it in the MIR validator too, but when it fails usign RevealAll, also try the check without it, to stop false negatives. Fixes rust-lang#99866 cc ```````@compiler-errors``````` who nicely helped me on zulip
…imulacrum Change implementation of `-Z gcc-ld` and `lld-wrapper` again This PR partially reverts rust-lang#97375 and uses the strategy described in rust-lang#97402 (comment) instead, thus fixes rust-lang#97755.
…s, r=davidtwco Migrate rustc_metadata to SessionDiagnostics Migrate rustc_metadata to SessionDiagnostics. Part of rust-lang#100717
… r=Mark-Simulacrum Also replace the version placeholder in rustc_attr Replace the version placeholder with the current version in the rustc_attr crate too so that users won't see the placeholder but instead the explicit version. This especially fixes the bug for rustdoc not showing it but instead the placeholder. Originally reported [here](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/libs.20stabilization.20placeholder/near/296057188). cc rust-lang#100591 
bump deps Update few crates to drop old/duplicated versions. updates pest* crates (no separate changelog, sadly: https://github.com/pest-parser/pest/releases), thiserror, handlebars(https://github.com/sunng87/handlebars-rust/blob/v4.3.3/CHANGELOG.md#433---2022-07-20) to drop old ones: ``` Removing block-buffer v0.7.3 Removing block-padding v0.1.5 Removing byte-tools v0.3.1 Removing byteorder v1.3.4 Removing digest v0.8.1 Removing fake-simd v0.1.2 Removing generic-array v0.12.4 Updating handlebars v4.1.0 -> v4.3.3 Removing opaque-debug v0.2.3 Updating pest v2.1.3 -> v2.3.0 Updating pest_derive v2.1.0 -> v2.3.0 Updating pest_generator v2.1.3 -> v2.3.0 Updating pest_meta v2.1.3 -> v2.3.0 Removing quick-error v2.0.0 Removing sha-1 v0.8.2 Updating thiserror v1.0.30 -> v1.0.33 Updating thiserror-impl v1.0.30 -> v1.0.33 ``` combine v4.6.3 -> v4.6.6: drops `use_std` features, addressed this comment: https://github.com/rust-lang/rust/blob/4fd4de7ea358ad6fc28c5780533ea8ccc09e1006/src/tools/rustc-workspace-hack/Cargo.toml#L80-L82 im-rc v15.0.0 -> v15.1.0 to drop rand_xoshiro duplicated version ``` Updating im-rc v15.0.0 -> v15.1.0 Removing rand_xoshiro v0.4.0 ```
Use `FILE_ATTRIBUTE_TAG_INFO` to get reparse tag I've been looking at this code recently and it just occurred to me we don't actually use the full reparse data at this point, only the tag. [`GetFileInformationByHandleEx`](https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getfileinformationbyhandleex) can do exactly that by filling a [`FILE_ATTRIBUTE_TAG_INFO`](https://docs.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-file_attribute_tag_info) struct. r? ``````@thomcc`````` since you've made changes here recently (which is why I have this code on my mind atm)
rustbot
added
T-bootstrap
davidtwco
removed
the
A-translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Z gcc-ldandlld-wrapperagain #100200 (Change implementation of-Z gcc-ldandlld-wrapperagain)FILE_ATTRIBUTE_TAG_INFOto get reparse tag #101260 (UseFILE_ATTRIBUTE_TAG_INFOto get reparse tag)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup