Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #101372

Closed
wants to merge 12 commits into from

Commits on Aug 31, 2022

  1. Add test for rust-lang#98294

    Add a test to make that the failure condition for this pattern is
    optimized away.
    
    Fixes rust-lang#98294.
    nikic committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    8a527ee View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. rustdoc: remove unused CSS selector .methods > .item-info

    It was added with e08a84a
    (actually, it was called `.methods > .stability` at the time) and was
    directly nested that way.
    
    But with the switch to `<details>`, the code has changed drastically out from
    under it, to the point where you have to go out of your way to actually get
    it to render this way, and the result looks overly-tight and weird alongside
    the normal version where this code is not reachable.
    notriddle committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    df09047 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f95c89 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0f29824 View commit details
    Browse the repository at this point in the history
  4. ffx component run should provide a collection

    In the future,`ffx component run` will not default to the using the `/core/ffx-laboratory` collection. Updated the run commands to include this.
    diminishedprime authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    c528f70 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Configuration menu
    Copy the full SHA
    b0f3a55 View commit details
    Browse the repository at this point in the history
  2. remove redundant clones

    matthiaskrgr committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    57198b5 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#101232 - nikic:issue-98294, r=Mark-Simulacrum

    Add test for rust-lang#98294
    
    Add a test to make that the failure condition for this pattern is optimized away.
    
    Fixes rust-lang#98294.
    matthiaskrgr authored Sep 3, 2022
    Configuration menu
    Copy the full SHA
    4f38523 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#101335 - notriddle:notriddle/methods-stabil…

    …ity, r=notriddle
    
    rustdoc: remove old CSS selector that causes weird spacing
    
    It was added with e08a84a (actually, it was called `.methods > .stability` at the time) and was directly nested that way.
    
    **EDIT**: It is technically reachable code still, but it seems wrong.
    
    ## With the old CSS rule still present
    
    https://notriddle.com/notriddle-rustdoc-test/weird-spacing/lib/struct.Foo.html
    
    ![image](https://user-images.githubusercontent.com/1593513/188216226-c667c560-d33d-494f-a492-4e0ec3ac0009.png)
    
    ## Version 2 (an older version of this PR)
    
    https://notriddle.com/notriddle-rustdoc-test/normal-spacing-2/lib/struct.Foo.html
    
    ![image](https://user-images.githubusercontent.com/1593513/188216418-9fcd3109-f1b2-425d-b4fc-0c6b3b54e48e.png)
    
    ## Version 3 (with alignment fix for mobile)
    
    https://notriddle.com/notriddle-rustdoc-test/normal-spacing-3/lib/struct.Foo.html
    
    ![image](https://user-images.githubusercontent.com/1593513/188223161-0e1ebce7-842f-41cb-8a0c-ae43aedcfccc.png)
    matthiaskrgr authored Sep 3, 2022
    Configuration menu
    Copy the full SHA
    6edfb53 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#101347 - diminishedprime:patch-4, r=tmandry

    ffx component run should provide a collection
    
    In the future,`ffx component run` will not default to the using the `/core/ffx-laboratory` collection. Updated the run commands to include this.
    matthiaskrgr authored Sep 3, 2022
    Configuration menu
    Copy the full SHA
    70f41ff View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#101364 - compiler-errors:arg-suggestion-spa…

    …ns, r=wesleywiser
    
    Shrink suggestion span of argument mismatch error
    
    This doesn't really help with rust-lang#101242, but I wanted to put this up while I work on other fixes.
    matthiaskrgr authored Sep 3, 2022
    Configuration menu
    Copy the full SHA
    2cd273d View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#101365 - matthiaskrgr:clones2, r=fee1-dead

    remove redundant clones
    matthiaskrgr authored Sep 3, 2022
    Configuration menu
    Copy the full SHA
    39c16eb View commit details
    Browse the repository at this point in the history