Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use futex-based locks and thread parker on Hermit #101475

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Use futex-based locks and thread parker on Hermit #101475

merged 1 commit into from
Sep 9, 2022

Conversation

joboet
Copy link
Member

@joboet joboet commented Sep 6, 2022

Hermit now has futex syscalls, which means Hermit can share the well-tested and performant locks and thread parker used on Linux.

Ping @mkroening, @stlankes
r? @m-ou-se

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 6, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Sep 6, 2022

Hermit now has futex syscalls

Nice!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 6, 2022

📌 Commit 24bf3d0c9571827291871688679eb382b1cf4af3 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2022
@m-ou-se m-ou-se mentioned this pull request Sep 6, 2022
Closed
63 tasks
@sanxiyn sanxiyn mentioned this pull request Sep 8, 2022
Closed
@bors
Copy link
Contributor

bors commented Sep 9, 2022

☔ The latest upstream changes (presumably #101592) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 9, 2022
@joboet joboet force-pushed the hermit_futex_locks branch from 24bf3d0 to 262193e Compare September 9, 2022 09:57
@joboet
Copy link
Member Author

joboet commented Sep 9, 2022

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Sep 9, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Sep 9, 2022

📌 Commit 262193e has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2022
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2022
@bors
Auto merge of rust-lang#101611 - GuillaumeGomez:rollup-yw3qtug, r=Gui…
1d37ed6 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#101475 (Use futex-based locks and thread parker on Hermit)
 - rust-lang#101492 (Suggest adding array lengths to references to arrays if possible)
 - rust-lang#101495 (Compile spin_loop_hint as pause on x86 even without sse2 enabled)
 - rust-lang#101529 (Fix the example code and doctest for Formatter::sign_plus)
 - rust-lang#101600 (rustdoc: simplify the codeblock tooltip)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 46dadd6 into rust-lang:master Sep 9, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 9, 2022
@joboet joboet deleted the hermit_futex_locks branch September 9, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
5 participants
@joboet @rustbot @m-ou-se @bors @rust-highfive