rustdoc: remove no-op CSS #settings-menu { padding: 0 }
#101584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CSS was added in 5e01ba3, and served to override CSS right above it that set a 5px padding for several kinds of buttons in the same toolbar. The CSS that it overrode is still there, but now it only applies to `#settings-menu > a`, so there's nothing to override.
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Sep 8, 2022
|
Thanks! r=me once CI pass |
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Sep 8, 2022
… r=GuillaumeGomez
rustdoc: remove no-op CSS `#settings-menu { padding: 0 }`
This CSS was added in 5e01ba3, and served to override CSS right above it that set a 5px padding for several kinds of buttons in the same toolbar:
https://github.com/rust-lang/rust/blob/5e01ba36c9f1037c4cf3e7421413fc6c41f85d05/src/librustdoc/html/static/css/rustdoc.css#L1400-L1409
The CSS that it overrode is still there, but now it only applies to `#settings-menu > a`, so there's nothing to override.
https://github.com/rust-lang/rust/blob/24d69920201563f0ee7b530f1cda0f171b205cc2/src/librustdoc/html/static/css/rustdoc.css#L1445-L1454
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 8, 2022
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#101423 (Fix hermit warnings) - rust-lang#101499 (Introduce lowering_arena to avoid creating AST nodes on the fly) - rust-lang#101530 (llvm-wrapper: adapt for LLVM API changes) - rust-lang#101554 (rustdoc: remove unused CSS `#implementations-list > h3 > span.in-band`) - rust-lang#101580 (rustdoc: remove unused CSS `div.impl-items > div`) - rust-lang#101584 (rustdoc: remove no-op CSS `#settings-menu { padding: 0 }`) - rust-lang#101587 (Make `Debug` impl for `Term` useful) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CSS was added in 5e01ba3, and served to override CSS right above it that set a 5px padding for several kinds of buttons in the same toolbar:
rust/src/librustdoc/html/static/css/rustdoc.css
Lines 1400 to 1409 in 5e01ba3
The CSS that it overrode is still there, but now it only applies to
#settings-menu > a, so there's nothing to override.rust/src/librustdoc/html/static/css/rustdoc.css
Lines 1445 to 1454 in 24d6992