Make `compare_predicate_entailment` no longer a query #101615

compiler-errors · 2022-09-09T15:35:10Z

Make compare_predicate_entailment so it's no longer a query (again), and splits out the new logic (that equates the return types to infer RPITITs) into its own query. This means that this new query (now called collect_trait_impl_trait_tys) is no longer executed for non-RPITIT cases.

This should improve perf (#101224 (comment)), though in practice we see that these some crates remain from the primary regressions list on the original report... They are all <= 0.43% regression and seemingly only on the incr-full scenario for all of them.

I am at a loss for what might be causing this regression other than what I fixed here, since we don't introduce much new non-RPITIT logic except for some def_kind query calls in some places, for example, like projection. Maybe that's it?

Originally this PR was opened to test enabling cache_on_disk (62164aaaa11) but that didn't turn out to be very useful (#101615 (comment)), so that led me to just split the query (and rename the PR).

compiler-errors · 2022-09-09T15:35:16Z

@bors try @rust-timer queue

rust-timer · 2022-09-09T15:35:18Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-09-09T15:35:24Z

⌛ Trying commit 112458bd85c9e8d2692233dce436912c88f35521 with merge 89b3f54f5de96e6fd11b7d992d9b64f335997aa5...

bors · 2022-09-09T15:45:38Z

💔 Test failed - checks-actions

compiler-errors · 2022-09-09T15:57:19Z

@bors try @rust-timer queue

rust-timer · 2022-09-09T15:57:21Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-09-09T15:57:27Z

⌛ Trying commit d2cd1b7c1d284dbf502e09f666c64150ce2abad2 with merge ee778fd79f1ba1246047b1f652c6ef0a135c1e49...

bors · 2022-09-09T17:33:27Z

☀️ Try build successful - checks-actions
Build commit: ee778fd79f1ba1246047b1f652c6ef0a135c1e49 (ee778fd79f1ba1246047b1f652c6ef0a135c1e49)

rust-timer · 2022-09-09T17:33:29Z

Queued ee778fd79f1ba1246047b1f652c6ef0a135c1e49 with parent 98f3001, future comparison URL.

rust-timer · 2022-09-09T19:56:22Z

Finished benchmarking commit (ee778fd79f1ba1246047b1f652c6ef0a135c1e49): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.3%]	3
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-1.5%	[-2.0%, -0.9%]	4
Improvements ✅ (secondary)	-2.0%	[-2.9%, -1.3%]	10
All ❌✅ (primary)	-1.5%	[-2.0%, -0.9%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

compiler-errors · 2022-09-09T22:05:16Z

@bors try @rust-timer queue

rust-timer · 2022-09-09T22:05:18Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-09-09T22:05:24Z

⌛ Trying commit 2e1da580dd11d4fdf8763638f771e41dfcfebd58 with merge 46ec702e9dd4258388a00180e4de0d629dfdad33...

compiler-errors · 2022-09-09T22:06:16Z

@bors try

rust-timer · 2022-09-10T01:41:53Z

Finished benchmarking commit (0531a017ad453e9f1bc2ab9193c17642e1ece6f2): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.6%, -0.3%]	7
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	5
All ❌✅ (primary)	-0.5%	[-0.6%, -0.3%]	7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[1.1%, 1.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.8%	[2.7%, 2.8%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[-2.2%, 2.8%]	3

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

compiler-errors · 2022-09-10T02:53:42Z

@bors try @rust-timer queue

r? @oli-obk just because you know this code, please feel free to reassign

rust-timer · 2022-09-10T02:53:43Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-09-10T02:53:50Z

⌛ Trying commit bec079d with merge 58c417521d7df5a75c6abc60cbba95b4e4b49f2b...

bors · 2022-09-10T04:44:10Z

☀️ Try build successful - checks-actions
Build commit: 58c417521d7df5a75c6abc60cbba95b4e4b49f2b (58c417521d7df5a75c6abc60cbba95b4e4b49f2b)

rust-timer · 2022-09-10T04:44:12Z

Queued 58c417521d7df5a75c6abc60cbba95b4e4b49f2b with parent 395e56f, future comparison URL.

rust-timer · 2022-09-10T06:52:04Z

Finished benchmarking commit (58c417521d7df5a75c6abc60cbba95b4e4b49f2b): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.5%, -0.4%]	6
Improvements ✅ (secondary)	-0.4%	[-0.6%, -0.3%]	5
All ❌✅ (primary)	-0.4%	[-0.5%, -0.4%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

oli-obk · 2022-09-13T11:27:11Z

@bors r+

bors · 2022-09-13T11:27:13Z

📌 Commit bec079d has been approved by oli-obk

It is now in the queue for this repository.

bors · 2022-09-13T15:33:10Z

⌛ Testing commit bec079d with merge 1ce5198...

bors · 2022-09-13T18:14:58Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 1ce5198 to master...

rust-timer · 2022-09-13T19:31:29Z

Finished benchmarking commit (1ce5198): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.5%, -0.4%]	6
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.3%]	5
All ❌✅ (primary)	-0.4%	[-0.5%, -0.4%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.7%, 3.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.7%	[1.7%, 3.8%]	2
Regressions ❌ (secondary)	3.3%	[2.8%, 3.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[1.7%, 3.8%]	2

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 9, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 9, 2022

compiler-errors added the F-return_position_impl_trait_in_trait `#![feature(return_position_impl_trait_in_trait)]` label Sep 9, 2022

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 9, 2022

compiler-errors force-pushed the rpitit-perf branch from 112458b to d2cd1b7 Compare September 9, 2022 15:56

rustbot added the A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) label Sep 9, 2022

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 9, 2022

compiler-errors force-pushed the rpitit-perf branch from d2cd1b7 to 2e1da58 Compare September 9, 2022 22:05

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 9, 2022

compiler-errors force-pushed the rpitit-perf branch from 2e1da58 to 62164aa Compare September 9, 2022 22:06

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 10, 2022

split compare_predicate_entailment and collect_trait_impl_trait_tys out

bec079d

compiler-errors force-pushed the rpitit-perf branch from 62164aa to bec079d Compare September 10, 2022 02:52

rust-highfive assigned oli-obk Sep 10, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 10, 2022

compiler-errors changed the title ~~cache compare_predicates_and_trait_impl_trait_tys~~ Make compare_predicate_entailment no longer a query Sep 10, 2022

compiler-errors marked this pull request as ready for review September 10, 2022 03:52

compiler-errors removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 10, 2022

compiler-errors mentioned this pull request Sep 12, 2022

Initial implementation of return-position impl Trait in traits #101224

Merged

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 13, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 13, 2022

bors merged commit 1ce5198 into rust-lang:master Sep 13, 2022

rustbot added this to the 1.65.0 milestone Sep 13, 2022

tmandry mentioned this pull request Nov 1, 2022

Tracking Issue for async_fn_in_trait, return_position_impl_trait_in_trait #91611

Closed

7 tasks

compiler-errors deleted the rpitit-perf branch November 2, 2022 02:58

matthiaskrgr mentioned this pull request Oct 30, 2023

ICE: failure to relate an opaque to itself should result in an error later on #117392

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `compare_predicate_entailment` no longer a query #101615

Make `compare_predicate_entailment` no longer a query #101615

compiler-errors commented Sep 9, 2022 •

edited

Loading

compiler-errors commented Sep 9, 2022

rust-timer commented Sep 9, 2022

bors commented Sep 9, 2022

bors commented Sep 9, 2022

compiler-errors commented Sep 9, 2022

rust-timer commented Sep 9, 2022

bors commented Sep 9, 2022

This comment was marked as outdated.

This comment has been minimized.

bors commented Sep 9, 2022

rust-timer commented Sep 9, 2022

rust-timer commented Sep 9, 2022

compiler-errors commented Sep 9, 2022

rust-timer commented Sep 9, 2022

bors commented Sep 9, 2022

compiler-errors commented Sep 9, 2022

rust-timer commented Sep 10, 2022

compiler-errors commented Sep 10, 2022

rust-timer commented Sep 10, 2022

bors commented Sep 10, 2022

bors commented Sep 10, 2022

rust-timer commented Sep 10, 2022

rust-timer commented Sep 10, 2022

oli-obk commented Sep 13, 2022

bors commented Sep 13, 2022

bors commented Sep 13, 2022

bors commented Sep 13, 2022

rust-timer commented Sep 13, 2022

Make compare_predicate_entailment no longer a query #101615

Make compare_predicate_entailment no longer a query #101615

Conversation

compiler-errors commented Sep 9, 2022 • edited Loading

compiler-errors commented Sep 9, 2022

rust-timer commented Sep 9, 2022

bors commented Sep 9, 2022

bors commented Sep 9, 2022

compiler-errors commented Sep 9, 2022

rust-timer commented Sep 9, 2022

bors commented Sep 9, 2022

This comment was marked as outdated.

This comment has been minimized.

bors commented Sep 9, 2022

rust-timer commented Sep 9, 2022

rust-timer commented Sep 9, 2022

Overall result: ❌✅ regressions and improvements - no action needed

Footnotes

compiler-errors commented Sep 9, 2022

rust-timer commented Sep 9, 2022

bors commented Sep 9, 2022

compiler-errors commented Sep 9, 2022

rust-timer commented Sep 10, 2022

Overall result: ✅ improvements - no action needed

Footnotes

compiler-errors commented Sep 10, 2022

rust-timer commented Sep 10, 2022

bors commented Sep 10, 2022

bors commented Sep 10, 2022

rust-timer commented Sep 10, 2022

rust-timer commented Sep 10, 2022

Overall result: ✅ improvements - no action needed

Footnotes

oli-obk commented Sep 13, 2022

bors commented Sep 13, 2022

bors commented Sep 13, 2022

bors commented Sep 13, 2022

rust-timer commented Sep 13, 2022

Overall result: ✅ improvements - no action needed

Footnotes

Make `compare_predicate_entailment` no longer a query #101615

Make `compare_predicate_entailment` no longer a query #101615

compiler-errors commented Sep 9, 2022 •

edited

Loading