Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic arg 'current_crate' #101678

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Add diagnostic arg 'current_crate' #101678

merged 1 commit into from
Sep 11, 2022

Conversation

jannic
Copy link
Contributor

@jannic jannic commented Sep 11, 2022

With this fix, I get almost the same error message as on stable, again.

However, I expected to get the new error message std is required by {$current_crate} because it does not declare #![no_std], but I didn't. Instead, I got a new line help: consider building the standard library from source with cargo build -Zbuild-std. So I obviously do not fully understand what is going on.

In any case, the bug itself seems to be fixed by this patch.

Closes #101640

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 11, 2022
@rust-highfive
Copy link
Collaborator

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2022
@jyn514
Copy link
Member

jyn514 commented Sep 11, 2022

@jannic "std is required" is only triggered if you've built core but not std: https://github.com/rust-lang/rust/pull/101678/files#diff-087de0fff21942e14f7f0d8c532ad2e4b0a7468734d934f3a5ac4ed82586e601R583-R586
You might be able to trigger it with -Zbuild-std=core.

@bors r+ rollup p=1 (fixes nightly breakage)

@bors
Copy link
Contributor

bors commented Sep 11, 2022

📌 Commit 156717d has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2022
@bors
Copy link
Contributor

bors commented Sep 11, 2022

⌛ Testing commit 156717d with merge 0d56e34...

@bors
Copy link
Contributor

bors commented Sep 11, 2022

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 0d56e34 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 11, 2022
@bors bors merged commit 0d56e34 into rust-lang:master Sep 11, 2022
@rustbot rustbot added this to the 1.65.0 milestone Sep 11, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0d56e34): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.6%, 1.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.4% [-5.4%, -5.4%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.0% [3.0%, 3.0%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

@davidtwco davidtwco added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc panicked when trying to compile once_cell
8 participants