-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostic arg 'current_crate' #101678
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
@jannic "std is required" is only triggered if you've built core but not std: https://github.com/rust-lang/rust/pull/101678/files#diff-087de0fff21942e14f7f0d8c532ad2e4b0a7468734d934f3a5ac4ed82586e601R583-R586 @bors r+ rollup p=1 (fixes nightly breakage) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (0d56e34): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
With this fix, I get almost the same error message as on stable, again.
However, I expected to get the new error message
std is required by {$current_crate} because it does not declare #![no_std]
, but I didn't. Instead, I got a new linehelp: consider building the standard library from source with cargo build -Zbuild-std
. So I obviously do not fully understand what is going on.In any case, the bug itself seems to be fixed by this patch.
Closes #101640