-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustdoc-Json: Fix Type docs. #101722
Rustdoc-Json: Fix Type docs. #101722
Conversation
Primitive doesn't include Array/Slice/Tuple, as they are their own variants. ResolvedPath doesn't include Traits, as they appear in the DynTrait variant.
(rust-highfive has picked a reviewer for you, use r? to override) |
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing |
r? rustdoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I remember being confused due to the overlap you point out and fix. This clears it up nicely 🚀
@bors r+ |
Rollup of 7 pull requests Successful merges: - rust-lang#101722 (Rustdoc-Json: Fix Type docs.) - rust-lang#101738 (Fix `#[link kind="raw-dylib"]` to respect `#[link_name]`) - rust-lang#101753 (Prefer explict closure sig types over expected ones) - rust-lang#101787 (cache `collect_trait_impl_trait_tys`) - rust-lang#101802 (Constify impl Fn* &(mut) Fn*) - rust-lang#101809 (Replace `check_missing_items.py` with `jsondoclint`) - rust-lang#101864 (rustdoc: remove no-op CSS `h1-4 { color: --main-color }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Primitive doesn't include Array/Slice/Tuple, as they are their own variants.
ResolvedPath doesn't include Traits, as they appear in the DynTrait variant.