Stabilize map_first_last #101727

est31 · 2022-09-12T16:22:29Z

Stabilizes the following functions:

impl<T> BTreeSet<T> {
    pub fn first(&self) -> Option<&T> where T: Ord;
    pub fn last(&self) -> Option<&T> where T: Ord;
    pub fn pop_first(&mut self) -> Option<T> where T: Ord;
    pub fn pop_last(&mut self) -> Option<T> where T: Ord;
}

impl<K, V> BTreeMap<K, V> {
    pub fn first_key_value(&self) -> Option<(&K, &V)> where K: Ord;
    pub fn last_key_value(&self) -> Option<(&K, &V)> where K: Ord;
    pub fn first_entry(&mut self) -> Option<OccupiedEntry<'_, K, V>> where K: Ord;
    pub fn last_entry(&mut self) -> Option<OccupiedEntry<'_, K, V>> where K: Ord;
    pub fn pop_first(&mut self) -> Option<(K, V)> where K: Ord;
    pub fn pop_last(&mut self) -> Option<(K, V)> where K: Ord;
}

Closes #62924

~~Blocked on the FCP finishing.~~ Edit: It finished!

rust-highfive · 2022-09-12T16:22:34Z

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

rustbot · 2022-09-12T16:22:34Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

est31 · 2022-09-13T13:50:12Z

@rustbot label +T-libs-api -T-libs +relnotes

est31 · 2022-09-29T09:42:26Z

r? @m-ou-se the FCP has finished so this is ready for merging :).

m-ou-se · 2022-09-30T12:52:09Z

@bors r+ rollup

bors · 2022-09-30T12:52:11Z

📌 Commit 3673e34 has been approved by m-ou-se

It is now in the queue for this repository.

…m-ou-se Stabilize map_first_last Stabilizes the following functions: ```Rust impl<T> BTreeSet<T> { pub fn first(&self) -> Option<&T> where T: Ord; pub fn last(&self) -> Option<&T> where T: Ord; pub fn pop_first(&mut self) -> Option<T> where T: Ord; pub fn pop_last(&mut self) -> Option<T> where T: Ord; } impl<K, V> BTreeMap<K, V> { pub fn first_key_value(&self) -> Option<(&K, &V)> where K: Ord; pub fn last_key_value(&self) -> Option<(&K, &V)> where K: Ord; pub fn first_entry(&mut self) -> Option<OccupiedEntry<'_, K, V>> where K: Ord; pub fn last_entry(&mut self) -> Option<OccupiedEntry<'_, K, V>> where K: Ord; pub fn pop_first(&mut self) -> Option<(K, V)> where K: Ord; pub fn pop_last(&mut self) -> Option<(K, V)> where K: Ord; } ``` Closes rust-lang#62924 ~~Blocked on the [FCP](rust-lang#62924 (comment)) finishing.~~ Edit: It finished!

matthiaskrgr · 2022-09-30T14:23:02Z

@bors r-
miri needs to be updated

 error: the feature `map_first_last` has been stable since 1.66.0-nightly and no longer requires an attribute to enable
 --> src/tools/miri/src/lib.rs:2:12
  |
2 | #![feature(map_first_last)]

rustbot · 2022-09-30T14:30:58Z

The Miri subtree was changed

cc @rust-lang/miri

est31 · 2022-09-30T16:01:33Z

@rustbot ready

est31 · 2022-10-09T00:33:45Z

@m-ou-se could you re-r+ this? Thanks :).

m-ou-se · 2022-10-11T14:22:53Z

@bors r+

bors · 2022-10-11T14:22:55Z

📌 Commit 2c72ea7 has been approved by m-ou-se

It is now in the queue for this repository.

…m-ou-se Stabilize map_first_last Stabilizes the following functions: ```Rust impl<T> BTreeSet<T> { pub fn first(&self) -> Option<&T> where T: Ord; pub fn last(&self) -> Option<&T> where T: Ord; pub fn pop_first(&mut self) -> Option<T> where T: Ord; pub fn pop_last(&mut self) -> Option<T> where T: Ord; } impl<K, V> BTreeMap<K, V> { pub fn first_key_value(&self) -> Option<(&K, &V)> where K: Ord; pub fn last_key_value(&self) -> Option<(&K, &V)> where K: Ord; pub fn first_entry(&mut self) -> Option<OccupiedEntry<'_, K, V>> where K: Ord; pub fn last_entry(&mut self) -> Option<OccupiedEntry<'_, K, V>> where K: Ord; pub fn pop_first(&mut self) -> Option<(K, V)> where K: Ord; pub fn pop_last(&mut self) -> Option<(K, V)> where K: Ord; } ``` Closes rust-lang#62924 ~~Blocked on the [FCP](rust-lang#62924 (comment)) finishing.~~ Edit: It finished!

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#100387 (Check uniqueness of impl items by trait item when applicable.) - rust-lang#101727 (Stabilize map_first_last) - rust-lang#101774 (Warn about safety of `fetch_update`) - rust-lang#102227 (fs::get_path solarish version.) - rust-lang#102445 (Add `is_empty()` method to `core::ffi::CStr`.) - rust-lang#102612 (Migrate `codegen_ssa` to diagnostics structs - [Part 1]) - rust-lang#102685 (Interpret EH actions properly) - rust-lang#102869 (Add basename and dirname aliases) - rust-lang#102889 (rustc_hir: Less error-prone methods for accessing `PartialRes` resolution) - rust-lang#102893 (Fix ICE rust-lang#102878) - rust-lang#102912 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…m-ou-se Stabilize map_first_last Stabilizes the following functions: ```Rust impl<T> BTreeSet<T> { pub fn first(&self) -> Option<&T> where T: Ord; pub fn last(&self) -> Option<&T> where T: Ord; pub fn pop_first(&mut self) -> Option<T> where T: Ord; pub fn pop_last(&mut self) -> Option<T> where T: Ord; } impl<K, V> BTreeMap<K, V> { pub fn first_key_value(&self) -> Option<(&K, &V)> where K: Ord; pub fn last_key_value(&self) -> Option<(&K, &V)> where K: Ord; pub fn first_entry(&mut self) -> Option<OccupiedEntry<'_, K, V>> where K: Ord; pub fn last_entry(&mut self) -> Option<OccupiedEntry<'_, K, V>> where K: Ord; pub fn pop_first(&mut self) -> Option<(K, V)> where K: Ord; pub fn pop_last(&mut self) -> Option<(K, V)> where K: Ord; } ``` Closes rust-lang#62924 ~~Blocked on the [FCP](rust-lang#62924 (comment)) finishing.~~ Edit: It finished!

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#100387 (Check uniqueness of impl items by trait item when applicable.) - rust-lang#101727 (Stabilize map_first_last) - rust-lang#101774 (Warn about safety of `fetch_update`) - rust-lang#102227 (fs::get_path solarish version.) - rust-lang#102445 (Add `is_empty()` method to `core::ffi::CStr`.) - rust-lang#102612 (Migrate `codegen_ssa` to diagnostics structs - [Part 1]) - rust-lang#102685 (Interpret EH actions properly) - rust-lang#102869 (Add basename and dirname aliases) - rust-lang#102889 (rustc_hir: Less error-prone methods for accessing `PartialRes` resolution) - rust-lang#102893 (Fix ICE rust-lang#102878) - rust-lang#102912 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned m-ou-se Sep 12, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 12, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 12, 2022

est31 mentioned this pull request Sep 12, 2022

Tracking issue for map_first_last: first/last methods on BTreeSet and BTreeMap #62924

Closed

6 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2022

matthiaskrgr mentioned this pull request Sep 30, 2022

Rollup of 6 pull requests #102515

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 30, 2022

est31 force-pushed the stabilize_map_first_last branch from 3673e34 to f9cc066 Compare September 30, 2022 14:30

Stabilize map_first_last

2c72ea7

est31 force-pushed the stabilize_map_first_last branch from f9cc066 to 2c72ea7 Compare September 30, 2022 15:00

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2022

Dylan-DPC mentioned this pull request Oct 11, 2022

Rollup of 8 pull requests #102920

Closed

matthiaskrgr mentioned this pull request Oct 11, 2022

Rollup of 11 pull requests #102926

Merged

bors merged commit cadb37a into rust-lang:master Oct 11, 2022

rustbot added this to the 1.66.0 milestone Oct 11, 2022

rmustacc mentioned this pull request Jun 20, 2023

gmake setup fails due to "unstable features" in pilot oxidecomputer/helios#93

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize map_first_last #101727

Stabilize map_first_last #101727

est31 commented Sep 12, 2022 •

edited

Loading

rust-highfive commented Sep 12, 2022

rustbot commented Sep 12, 2022

est31 commented Sep 13, 2022

est31 commented Sep 29, 2022

m-ou-se commented Sep 30, 2022

bors commented Sep 30, 2022

matthiaskrgr commented Sep 30, 2022

rustbot commented Sep 30, 2022

est31 commented Sep 30, 2022

est31 commented Oct 9, 2022

m-ou-se commented Oct 11, 2022

bors commented Oct 11, 2022

Stabilize map_first_last #101727

Stabilize map_first_last #101727

Conversation

est31 commented Sep 12, 2022 • edited Loading

rust-highfive commented Sep 12, 2022

rustbot commented Sep 12, 2022

est31 commented Sep 13, 2022

est31 commented Sep 29, 2022

m-ou-se commented Sep 30, 2022

bors commented Sep 30, 2022

matthiaskrgr commented Sep 30, 2022

rustbot commented Sep 30, 2022

est31 commented Sep 30, 2022

est31 commented Oct 9, 2022

m-ou-se commented Oct 11, 2022

bors commented Oct 11, 2022

est31 commented Sep 12, 2022 •

edited

Loading