Rollup of 6 pull requests

[Dylan-DPC]

Successful merges:

• incremental: migrate diagnostics #100754 (incremental: migrate diagnostics)
• Fix #[link kind="raw-dylib"] to respect #[link_name] #101738 (Fix #[link kind="raw-dylib"] to respect #[link_name])
• Prefer explict closure sig types over expected ones #101753 (Prefer explict closure sig types over expected ones)
• cache collect_trait_impl_trait_tys #101787 (cache collect_trait_impl_trait_tys)
• Constify impl Fn* &(mut) Fn* #101802 (Constify impl Fn* &(mut) Fn*)
• Replace check_missing_items.py with jsondoclint #101809 (Replace check_missing_items.py with jsondoclint)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[Dylan-DPC]

@bors r+ rollup=never p=5

[bors]

📌 Commit fe61d29 has been approved by Dylan-DPC

It is now in the queue for this repository.

[bors]

⌛ Testing commit fe61d29 with merge 237cdc2b1025157cbf4a7b478b7f767540a4e965...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job wasm32 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING] compile::Assemble { target_compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu } } -- 0.012
[TIMING] compile::StartupObjects { compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu }, target: wasm32-unknown-emscripten } -- 0.000
[TIMING] builder::Builder::sysroot_libdir::Libdir { compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu }, target: wasm32-unknown-emscripten } -- 0.000
Building stage2 std artifacts (x86_64-unknown-linux-gnu -> wasm32-unknown-emscripten)
error: output of --print=file-names has changed in the compiler, cannot parse
command was: `/checkout/obj/build/bootstrap/debug/rustc - --crate-name ___ --print=file-names -Csymbol-mangling-version=legacy -Zunstable-options -Zunstable-options '--check-cfg=values(bootstrap)' '--check-cfg=values(stdarch_intel_sde)' '--check-cfg=values(no_fp_fmt_parse)' '--check-cfg=values(no_global_oom_handling)' '--check-cfg=values(freebsd12)' '--check-cfg=values(backtrace_in_libstd)' '--check-cfg=values(target_env,"libnx")' '--check-cfg=values(target_os,"watchos")' '--check-cfg=values(target_arch,"asmjs","spirv","nvptx","nvptx64","le32","xtensa")' '--check-cfg=values(dont_compile_me)' -Zmacro-backtrace -Zunstable-options -Csplit-debuginfo=off -Cprefer-dynamic -Cembed-bitcode=yes '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/")' --target wasm32-unknown-emscripten --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg`
--- stdout
___.js
___.js
lib___.rlib
___.wasm
lib___.a
debug_assertions
panic="unwind"
proc_macro
target_abi=""
target_abi=""
target_arch="wasm32"
target_endian="little"
target_env=""
Build completed unsuccessfully in 0:08:34
target_family="unix"
target_family="wasm"
target_feature="llvm14-builtins-abi"
target_has_atomic="16"
target_has_atomic="32"
target_has_atomic="64"
target_has_atomic="8"
target_has_atomic="ptr"
target_has_atomic_equal_alignment="16"
target_has_atomic_equal_alignment="32"
target_has_atomic_equal_alignment="64"
target_has_atomic_equal_alignment="8"
target_has_atomic_equal_alignment="ptr"
target_has_atomic_load_store="16"
target_has_atomic_load_store="32"
target_has_atomic_load_store="64"
target_has_atomic_load_store="8"
target_has_atomic_load_store="ptr"
target_os="emscripten"
target_pointer_width="32"
target_thread_local
target_vendor="unknown"

--- stderr
warning: dropping unsupported crate type `dylib` for target `wasm32-unknown-emscripten`


warning: 1 warning emitted

[RUSTC-TIMING] ___ test:false 0.019

[dpaoliello]

@Dylan-DPC @wesleywiser

I believe that this failed due to #100754

If I'm reading parse_crate_type (https://github.com/rust-lang/cargo/blob/master/src/cargo/core/compiler/build_context/target_info.rs#L505) correctly, then it should have returned early after detecting "unsupported crate type" in the output, and so should have never raised the "output of --print=file-names has changed in the compiler, cannot parse" error.

Is it possible that #100754 caused the warning to be emitted to stderr instead of stdout (https://github.com/rust-lang/rust/pull/100754/files#diff-96da842aaf6582a52b9f23b4b353ef42214149dfb874819da8b616bacfb4b43eL574), which Cargo isn't scanning through?

[wesleywiser]

Yeah, I believe you are correct @dpaoliello. #100754 failed when bors tried merging it a few hours ago. #100754 (comment)

I'll r+ your PR again.