-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootstrap compiler to 1.65.0 #102051
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Seems like Lines 199 to 200 in 8fd6d03
Adding the same previous line but with (Some(Mode::ToolRustc), "parallel_compiler", None),
+ (Some(Mode::Codegen), "parallel_compiler", None), Sorry for the inconvenience should have checked more closely when adding those. |
Thanks for the quick comment! Applied your patch. |
This comment has been minimized.
This comment has been minimized.
r=me with CI fixed. |
@bors r=Mark-Simulacrum p=1 |
📌 Commit f026e117b0b5c28ce4a9d1eb53d46b628e58699e has been approved by It is now in the queue for this repository. |
⌛ Testing commit f026e117b0b5c28ce4a9d1eb53d46b628e58699e with merge 0ddedcf0f320ec78233123ef8517d7c43acccd55... |
💔 Test failed - checks-actions |
|
@bors r=Mark-Simulacrum |
📌 Commit df752e839c0f43b0eb8dec050757691210770f5a has been approved by It is now in the queue for this repository. |
@davidtwco yeah it's better to do it in a followup PR. |
Finished benchmarking commit (e1d7dec): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Footnotes |
@rustbot label: +perf-regression-triaged |
In rust-lang#101230, the internal diagnostic migration lints - `diagnostic_outside_of_impl` and `untranslatable_diagnostic` - were modified so that they wouldn't trigger on functions annotated with `#[rustc_lint_diagnostics]`. However, this change has to make it into the bootstrap compiler before the `#[allow]` annotations that it aims to remove can be removed, which is possible now that rust-lang#102051 has landed. Signed-off-by: David Wood <david.wood@huawei.com>
…mp-allow-lint, r=lcnr session: remove now-unnecessary lint `#[allow]`s In rust-lang#101230, the internal diagnostic migration lints - `diagnostic_outside_of_impl` and `untranslatable_diagnostic` - were modified so that they wouldn't trigger on functions annotated with `#[rustc_lint_diagnostics]`. However, this change has to make it into the bootstrap compiler before the `#[allow]` annotations that it aims to remove can be removed, which is possible now that rust-lang#102051 has landed.
…mp-allow-lint, r=lcnr session: remove now-unnecessary lint `#[allow]`s In rust-lang#101230, the internal diagnostic migration lints - `diagnostic_outside_of_impl` and `untranslatable_diagnostic` - were modified so that they wouldn't trigger on functions annotated with `#[rustc_lint_diagnostics]`. However, this change has to make it into the bootstrap compiler before the `#[allow]` annotations that it aims to remove can be removed, which is possible now that rust-lang#102051 has landed.
Confirming noise - see #102292 (comment) for some graphs. |
…mp-allow-lint, r=lcnr session: remove now-unnecessary lint `#[allow]`s In rust-lang#101230, the internal diagnostic migration lints - `diagnostic_outside_of_impl` and `untranslatable_diagnostic` - were modified so that they wouldn't trigger on functions annotated with `#[rustc_lint_diagnostics]`. However, this change has to make it into the bootstrap compiler before the `#[allow]` annotations that it aims to remove can be removed, which is possible now that rust-lang#102051 has landed.
…mp-allow-lint, r=lcnr session: remove now-unnecessary lint `#[allow]`s In rust-lang#101230, the internal diagnostic migration lints - `diagnostic_outside_of_impl` and `untranslatable_diagnostic` - were modified so that they wouldn't trigger on functions annotated with `#[rustc_lint_diagnostics]`. However, this change has to make it into the bootstrap compiler before the `#[allow]` annotations that it aims to remove can be removed, which is possible now that rust-lang#102051 has landed.
This PR updates the bootstrap compiler to Rust 1.65.0, removing the various
cfg(bootstrap)
s.r? @Mark-Simulacrum