Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to clippy::non_expressive_names doc #102123

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Conversation

schteve
Copy link
Contributor

@schteve schteve commented Sep 22, 2022

Addresses confusion in rust-lang/rust-clippy#9514 by updating the lint docs.

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2022
@Manishearth
Copy link
Member

@bors r+ rollup

This PR probably should be made to the clippy repo but it's not a big deal either way.

It'll land faster on clippy though :)

@bors
Copy link
Contributor

bors commented Sep 22, 2022

📌 Commit 51c752a has been approved by Manishearth

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2022
@schteve
Copy link
Contributor Author

schteve commented Sep 22, 2022

What is the distinction between the clippy in rust and the clippy in rust-clippy? I didn't realize there were two separate codebases.
Will this PR here automatically be merged into rust-clippy or should I submit a new PR there?

@Manishearth
Copy link
Member

They're periodically synced, rust-clippy is the authoritative source however we have a copy here so that rustc PRs can fix clippy breakages.

If the PR touches only clippy, it's better to make it to the clippy repo

@schteve
Copy link
Contributor Author

schteve commented Sep 22, 2022

Ok, thanks for the explanation, makes sense. For this PR then I will wait for the sync to happen even if it's a bit slow. Next time I'll go to rust-clippy directly.

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2022
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#102113 (OpTy: fix a method taking self rather than &self)
 - rust-lang#102118 (rustdoc: clean up line numbers on code examples)
 - rust-lang#102123 (Add note to clippy::non_expressive_names doc)
 - rust-lang#102125 (rustdoc: remove no-op CSS `.content .item-info { position: relative }`)
 - rust-lang#102127 (Use appropriate variable names)
 - rust-lang#102128 (Const unification is already infallible, remove the error handling logic)
 - rust-lang#102133 (Use valtrees for comparison)
 - rust-lang#102135 (Improve some AllTypes fields name)
 - rust-lang#102144 (Extend const_convert with const {FormResidual, Try} for ControlFlow.)
 - rust-lang#102147 (rustdoc: remove no-op CSS `.location:empty { border: none }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 86acea4 into rust-lang:master Sep 23, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 23, 2022
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 6, 2022
Add note to clippy::non_expressive_names doc

Addresses confusion in rust-lang/rust-clippy#9514 by updating the lint docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants