Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize bench_black_box #102232

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Stabilize bench_black_box #102232

merged 1 commit into from
Sep 28, 2022

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Sep 24, 2022

This PR stabilize feature(bench_black_box).

pub fn black_box<T>(dummy: T) -> T;

The FCP was completed in #64102.

@rustbot label +T-libs-api -T-libs

@rust-highfive
Copy link
Collaborator

r? @TaKO8Ki

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 24, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2022

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

The Miri subtree was changed

cc @rust-lang/miri

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2022
@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 24, 2022
@bjorn3 bjorn3 mentioned this pull request Sep 24, 2022
Open
89 tasks
@inquisitivecrystal inquisitivecrystal added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 25, 2022
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Sep 26, 2022

@bors try

@bors
Copy link
Contributor

bors commented Sep 27, 2022

⌛ Trying commit aca404a with merge 845c7c08e2975c6d6aaf8df0d4c4956ff9f1179c...

@bors
Copy link
Contributor

bors commented Sep 27, 2022

☀️ Try build successful - checks-actions
Build commit: 845c7c08e2975c6d6aaf8df0d4c4956ff9f1179c (845c7c08e2975c6d6aaf8df0d4c4956ff9f1179c)

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Sep 27, 2022

@bors r+ rollup since FCP completed

@bors
Copy link
Contributor

bors commented Sep 27, 2022

📌 Commit aca404a has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 27, 2022
@Dylan-DPC
Rollup merge of rust-lang#102232 - Urgau:stabilize-bench_black_box, r…
91578c0 
…=TaKO8Ki

Stabilize bench_black_box

This PR stabilize `feature(bench_black_box)`.

```rust
pub fn black_box<T>(dummy: T) -> T;
```

The FCP was completed in rust-lang#64102.

`@rustbot` label +T-libs-api -T-libs
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 27, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 27, 2022
@Dylan-DPC
Rollup merge of rust-lang#102232 - Urgau:stabilize-bench_black_box, r…
c168af8 
…=TaKO8Ki

Stabilize bench_black_box

This PR stabilize `feature(bench_black_box)`.

```rust
pub fn black_box<T>(dummy: T) -> T;
```

The FCP was completed in rust-lang#64102.

``@rustbot`` label +T-libs-api -T-libs
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 27, 2022
Closed
@fee1-dead
Copy link
Member

fee1-dead commented Sep 27, 2022 •
edited
Loading

@bors r-

Failed in a rollup, per #102358 (comment).

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 27, 2022
@Urgau Urgau force-pushed the stabilize-bench_black_box branch from aca404a to 9ad2f00 Compare September 27, 2022 15:39
@Urgau
Copy link
Member Author

Urgau commented Sep 27, 2022 •
edited
Loading

Fixed by applying the patch from @cuviper in #102358 (comment).

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2022
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Sep 28, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 28, 2022

📌 Commit 9ad2f00 has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2022
@JohnTitor JohnTitor mentioned this pull request Sep 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2022
@bors
Auto merge of rust-lang#102388 - JohnTitor:rollup-mbyw6fl, r=JohnTitor
837bf37 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#100747 (Add long description and test for E0311)
 - rust-lang#102232 (Stabilize bench_black_box)
 - rust-lang#102288 (Suggest unwrapping `???<T>` if a method cannot be found on it but is present on `T`.)
 - rust-lang#102338 (Deny associated type bindings within associated type bindings)
 - rust-lang#102347 (Unescaping cleanups)
 - rust-lang#102348 (Tweak `FulfillProcessor`.)
 - rust-lang#102378 (Use already resolved `self_ty` in `confirm_fn_pointer_candidate`)
 - rust-lang#102380 (rustdoc: remove redundant mobile `.source > .sidebar` CSS)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 07bb2e6 into rust-lang:master Sep 28, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 28, 2022
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@JohnTitor
Rollup merge of rust-lang#102232 - Urgau:stabilize-bench_black_box, r…
985cc02 
…=TaKO8Ki

Stabilize bench_black_box

This PR stabilize `feature(bench_black_box)`.

```rust
pub fn black_box<T>(dummy: T) -> T;
```

The FCP was completed in rust-lang#64102.

`@rustbot` label +T-libs-api -T-libs
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#102388 - JohnTitor:rollup-mbyw6fl, r=JohnTitor
cf62e8a 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#100747 (Add long description and test for E0311)
 - rust-lang#102232 (Stabilize bench_black_box)
 - rust-lang#102288 (Suggest unwrapping `???<T>` if a method cannot be found on it but is present on `T`.)
 - rust-lang#102338 (Deny associated type bindings within associated type bindings)
 - rust-lang#102347 (Unescaping cleanups)
 - rust-lang#102348 (Tweak `FulfillProcessor`.)
 - rust-lang#102378 (Use already resolved `self_ty` in `confirm_fn_pointer_candidate`)
 - rust-lang#102380 (rustdoc: remove redundant mobile `.source > .sidebar` CSS)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@apiraino apiraino mentioned this pull request Feb 14, 2023
Open
@leso-kn leso-kn mentioned this pull request Feb 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TaKO8Ki TaKO8Ki

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Urgau @rust-highfive @rustbot @TaKO8Ki @bors @fee1-dead @inquisitivecrystal