Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for use of index-based lifetime names in print of binder #102399

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

b-naber
Copy link
Contributor

@b-naber b-naber commented Sep 28, 2022

Fixes #102374

r? @lcnr

cc @steffahn

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 28, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2022
@lcnr
Copy link
Contributor

lcnr commented Sep 28, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 28, 2022

📌 Commit a670897 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Sep 29, 2022
Account for use of index-based lifetime names in print of binder

Fixes rust-lang#102374

r? `@lcnr`

cc `@steffahn`
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Sep 29, 2022
Account for use of index-based lifetime names in print of binder

Fixes rust-lang#102374

r? ``@lcnr``

cc ``@steffahn``
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#98368 (Make `std::os::fd` public.)
 - rust-lang#102085 (Code refactoring smart_resolve_report_errors)
 - rust-lang#102351 (Improve E0585 help)
 - rust-lang#102368 (Add a niche to `Duration`, unix `SystemTime`, and non-apple `Instant`)
 - rust-lang#102393 (Add regression test for issue 94923)
 - rust-lang#102399 (Account for use of index-based lifetime names in print of binder)
 - rust-lang#102416 (remove FIXME, improve documentation)
 - rust-lang#102433 (env::temp_dir: fix a typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 039e9e2 into rust-lang:master Sep 29, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 29, 2022
@b-naber b-naber deleted the binder-print-ice branch September 29, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE with new collision-avoiding lifetime printing logic
5 participants