Group together more size assertions. #102493
Merged
+37
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors rollup=always |
|
@bors r+ rollup |
|
📌 Commit dabb5f07700bd6203d97867ec3ab1f9572fc3ba6 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
Kobzol
reviewed
Sep 30, 2022
compiler/rustc_ast/src/token.rs
Outdated
| static_assert_size!(LitKind, 2); | ||
| static_assert_size!(Token, 24); | ||
| static_assert_size!(TokenKind, 16); | ||
| static_assert_size!(Nonterminal, 16); |
There was a problem hiding this comment.
The last one is not in alphabetical order :)
|
@bors r- I'll fix the ordering on Monday. |
bors
added
S-waiting-on-author
Also add a few more assertions for some relevant token-related types. And fix an erroneous comment in `rustc_errors`.
nnethercote
force-pushed
the
improve-size-assertions-some-more
branch
from
dabb5f0 to
5ab68a8
Compare
|
I fixed the ordering. @bors r=lqd rollup=always |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 1, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#102361 (Fix ICE in const_trait check code) - rust-lang#102373 (Flush delayed bugs before codegen) - rust-lang#102483 (create def ids for impl traits during ast lowering) - rust-lang#102490 (Generate synthetic region from `impl` even in closure body within an associated fn) - rust-lang#102492 (Don't lower assoc bindings just to deny them) - rust-lang#102493 (Group together more size assertions.) - rust-lang#102521 (rustdoc: add missing margin to no-docblock methods) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a few more assertions for some relevant token-related types.
And fix an erroneous comment in
rustc_errors.r? @lqd