Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tuple candidate, nothing special about it #102786

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Oct 7, 2022

r? @lcnr you mentioned this during the talk you gave i think

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 7, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 7, 2022
@compiler-errors
Copy link
Member Author

The other "builtin"-like candidates (pointee, discriminantkind) are a bit harder to remove since they have special projection logic... I'm working on a solution for pointee I think

@lcnr
Copy link
Contributor

lcnr commented Oct 10, 2022

👍

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 10, 2022

📌 Commit 8b9a1f1 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#99696 (Uplift `clippy::for_loops_over_fallibles` lint into rustc)
 - rust-lang#102055 (Move some tests to more reasonable directories)
 - rust-lang#102786 (Remove tuple candidate, nothing special about it)
 - rust-lang#102794 (Make tests capture the error printed by a Result return)
 - rust-lang#102853 (Skip chained OpaqueCast when building captures.)
 - rust-lang#102868 (Rename `AssocItemKind::TyAlias` to `AssocItemKind::Type`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 58d533d into rust-lang:master Oct 10, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 10, 2022
@compiler-errors compiler-errors deleted the no-tuple-candidate branch November 2, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants