Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rustdoc unsafe-fn GUI test #103011

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Improve rustdoc unsafe-fn GUI test #103011

merged 2 commits into from
Oct 14, 2022

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 13, 2022
@rustbot rustbot added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Oct 13, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2022
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between fa0ca783f89a83046e6ce0383385ba5b28296435 and 26e5fec2e775e184aba26f929f785e04b127e17f
Rustdoc was updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
Step 11/14 : COPY host-x86_64/x86_64-gnu-tools/browser-ui-test.version /tmp/
 ---> c5703b12b0d7
Step 12/14 : RUN npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true
 ---> Running in 17fc39363a2c
npm ERR! code ETARGET
npm ERR! notarget No matching version found for browser-ui-test@0.12.3.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-10-13T14_55_07_559Z-debug.log
The command '/bin/sh -c npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true' returned a non-zero code: 1
Sending build context to Docker daemon  543.2kB

Step 1/14 : FROM ubuntu:22.04
 ---> 216c552ea5ba
---
 ---> Using cache
 ---> c5703b12b0d7
Step 12/14 : RUN npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true
 ---> Running in 3944b6515d09
npm ERR! code ETARGET
npm ERR! notarget No matching version found for browser-ui-test@0.12.3.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-10-13T14_55_10_010Z-debug.log
The command '/bin/sh -c npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true' returned a non-zero code: 1
Sending build context to Docker daemon  543.2kB

Step 1/14 : FROM ubuntu:22.04
 ---> 216c552ea5ba
---
 ---> Using cache
 ---> c5703b12b0d7
Step 12/14 : RUN npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true
 ---> Running in a5a92008d7c7
npm ERR! code ETARGET
npm ERR! notarget No matching version found for browser-ui-test@0.12.3.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-10-13T14_55_13_465Z-debug.log
The command '/bin/sh -c npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true' returned a non-zero code: 1
Sending build context to Docker daemon  543.2kB

Step 1/14 : FROM ubuntu:22.04
 ---> 216c552ea5ba
---
 ---> Using cache
 ---> c5703b12b0d7
Step 12/14 : RUN npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true
 ---> Running in 40aa5ca8d698
npm ERR! code ETARGET
npm ERR! notarget No matching version found for browser-ui-test@0.12.3.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-10-13T14_55_17_635Z-debug.log
The command '/bin/sh -c npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true' returned a non-zero code: 1
Sending build context to Docker daemon  543.2kB

Step 1/14 : FROM ubuntu:22.04
 ---> 216c552ea5ba
---
 ---> Using cache
 ---> c5703b12b0d7
Step 12/14 : RUN npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true
 ---> Running in 43870a4bd0a4
npm ERR! code ETARGET
npm ERR! notarget No matching version found for browser-ui-test@0.12.3.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-10-13T14_55_22_790Z-debug.log
The command '/bin/sh -c npm install -g browser-ui-test@$(head -n 1 /tmp/browser-ui-test.version) --unsafe-perm=true' returned a non-zero code: 1
##[error]Process completed with exit code 1.
Post job cleanup.

@GuillaumeGomez
Copy link
Member Author

I somehow forgot to press enter to publish the new package version... Restarted CI.

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 13, 2022

📌 Commit 16cfd6c has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 13, 2022
@matthiaskrgr
Rollup merge of rust-lang#103011 - GuillaumeGomez:improve-unsafe-fn-g…
850e65a 
…ui-test, r=notriddle

Improve rustdoc `unsafe-fn` GUI test

r? `@notriddle`
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 13, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2022
@bors
Auto merge of rust-lang#103026 - matthiaskrgr:rollup-gfmlfkt, r=matth…
edabf59 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#103000 (Add suggestion to the "missing native library" error)
 - rust-lang#103006 (rustdoc: don't ICE on `TyKind::Typeof`)
 - rust-lang#103008 (replace ReErased with fresh region vars in opaque types)
 - rust-lang#103011 (Improve rustdoc `unsafe-fn` GUI test)
 - rust-lang#103013 (Add new bootstrap entrypoints to triagebot)
 - rust-lang#103016 (Ensure enum cast moves)
 - rust-lang#103021 (Add links to relevant pages to find constraint information)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f156cc into rust-lang:master Oct 14, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 14, 2022
@GuillaumeGomez GuillaumeGomez deleted the improve-unsafe-fn-gui-test branch October 14, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-log-analyzer @notriddle @bors @rust-highfive @rustbot