Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More dupe word typos #103018

Merged
merged 1 commit into from
Oct 14, 2022
Merged

More dupe word typos #103018

merged 1 commit into from
Oct 14, 2022

Conversation

Rageking8
Copy link
Contributor

@Rageking8 Rageking8 commented Oct 13, 2022 •
edited
Loading

I only picked those changes (from the regex search) that I am pretty certain doesn't change meaning and is just a typo fix. Do correct me if any fix is undesirable and I can revert those. Thanks.

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 13, 2022
@rust-highfive
Copy link
Collaborator

r? @TaKO8Ki

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2022

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in const_evaluatable.rs

cc @lcnr

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2022
@saethlin
Copy link
Member

I feel like there's some kind of study one could do on the kinds of spelling and grammar mistakes people often make, based on how many mistakes you've found here.

Thanks for finding these ❤️

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Oct 14, 2022

r=me after the nits are addressed

@Rageking8
Copy link
Contributor Author

I feel like there's some kind of study one could do on the kinds of spelling and grammar mistakes people often make, based on how many mistakes you've found here.

Thanks for finding these ❤️

Haha, there are at least 20-30 more in submodules which are not covered in this PR, together with a bunch that I am not sure about. I think the reason why so many duplicate words typo slip through reviews is because when proof reading the brain kinda just "filters" out the extra word. Leading to this many being found.

@Rageking8
Copy link
Contributor Author

@bors r=TaKO8Ki

@bors
Copy link
Contributor

bors commented Oct 14, 2022

@Rageking8: 🔑 Insufficient privileges: Not in reviewers

@Rageking8
Copy link
Contributor Author

Ya, I don't have perms, need a manual r+. Thanks.

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Oct 14, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 14, 2022

📌 Commit 7122aba has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 14, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 14, 2022
@Dylan-DPC
Rollup merge of rust-lang#103018 - Rageking8:more-dupe-word-typos, r=…
49780e9 
…TaKO8Ki

More dupe word typos

I only picked those changes (from the regex search) that I am pretty certain doesn't change meaning and is just a typo fix. Do correct me if any fix is undesirable and I can revert those. Thanks.
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2022
@bors
Auto merge of rust-lang#103048 - Dylan-DPC:rollup-47r62js, r=Dylan-DPC
9b0a099 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#102847 (impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions)
 - rust-lang#102856 (Only test duplicate inherent impl items in a single place)
 - rust-lang#102914 (Migrate css highlight without change)
 - rust-lang#102938 (Move some tests to more reasonable directories)
 - rust-lang#103015 (fix a typo)
 - rust-lang#103018 (More dupe word typos)
 - rust-lang#103025 (rustdoc: remove unused CSS `.search-container > *`)
 - rust-lang#103031 (Suppress irrefutable let patterns lint for prefixes in match guards)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
albertlarsan68 added a commit to albertlarsan68/rust that referenced this pull request Oct 14, 2022
@albertlarsan68
Rollup merge of rust-lang#103018 - Rageking8:more-dupe-word-typos, r=…
18d52f9 
…TaKO8Ki

More dupe word typos

I only picked those changes (from the regex search) that I am pretty certain doesn't change meaning and is just a typo fix. Do correct me if any fix is undesirable and I can revert those. Thanks.
@albertlarsan68 albertlarsan68 mentioned this pull request Oct 14, 2022
Closed
albertlarsan68 added a commit to albertlarsan68/rust that referenced this pull request Oct 14, 2022
@albertlarsan68
Rollup merge of rust-lang#103048 - Dylan-DPC:rollup-47r62js, r=Dylan-DPC
97b0ece 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#102847 (impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions)
 - rust-lang#102856 (Only test duplicate inherent impl items in a single place)
 - rust-lang#102914 (Migrate css highlight without change)
 - rust-lang#102938 (Move some tests to more reasonable directories)
 - rust-lang#103015 (fix a typo)
 - rust-lang#103018 (More dupe word typos)
 - rust-lang#103025 (rustdoc: remove unused CSS `.search-container > *`)
 - rust-lang#103031 (Suppress irrefutable let patterns lint for prefixes in match guards)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 77064b7 into rust-lang:master Oct 14, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 14, 2022
@Rageking8 Rageking8 deleted the more-dupe-word-typos branch October 17, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saethlin saethlin saethlin left review comments

Assignees

@TaKO8Ki TaKO8Ki

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Rageking8 @rust-highfive @rustbot @saethlin @TaKO8Ki @bors