Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More alphabetical sorting #103067

Merged
merged 3 commits into from
Oct 15, 2022
Merged

More alphabetical sorting #103067

merged 3 commits into from
Oct 15, 2022

Conversation

Noratrieb
Copy link
Member

Sort and enforce a few more things. The biggest change here is sorting all target features.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 14, 2022
@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2022

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2022
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 14, 2022

📌 Commit b00cb04 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2022
@bors
Auto merge of rust-lang#103069 - matthiaskrgr:rollup-xxsx6sk, r=matth…
8147e6e 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#102092 (refactor: use grep -E/-F instead of fgrep/egrep)
 - rust-lang#102781 (Improved documentation for `std::io::Error`)
 - rust-lang#103017 (Avoid dropping TLS Key on sgx)
 - rust-lang#103039 (checktools: fix comments)
 - rust-lang#103045 (Remove leading newlines from integer primitive doc examples)
 - rust-lang#103047 (Update browser-ui-test version to fix some flaky tests)
 - rust-lang#103054 (Clean up rust-logo rustdoc GUI test)
 - rust-lang#103059 (Fix `Duration::{try_,}from_secs_f{32,64}(-0.0)`)
 - rust-lang#103067 (More alphabetical sorting)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a96f1a8 into rust-lang:master Oct 15, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 15, 2022
@Noratrieb Noratrieb deleted the tidy-likes-the-alphabet branch October 15, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Noratrieb @rust-highfive @rustbot @jackh726 @bors