Kill array_assume_init #103134

SUPERCILEX · 2022-10-17T04:03:09Z

No longer needed with transpose.

rustbot · 2022-10-17T04:03:12Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

SUPERCILEX · 2022-10-17T05:34:34Z

I don't see hashbrown in the rust source: do I have to fix this by patching hashbrown, waiting for them to release, and then pulling in that new version into rust?

library/core/src/mem/maybe_uninit.rs

Noratrieb · 2022-10-17T07:38:21Z

library/core/tests/mem.rs

@@ -161,22 +161,6 @@ fn assume_init_good() {
    assert!(TRUE);
 }

-#[test]
-fn uninit_array_assume_init() {


Is there an equivalent test for transpose already?

Maybe? There are doc tests, but again transpose is NOT assume_init so I'm not sure what we'd be testing (that transmute works?).

We'd be testing that this same behavior still works with the new methods, which sounds useful to me.

Sounds good, added back.

scottmcm · 2022-10-17T18:21:31Z

library/core/src/mem/maybe_uninit.rs

-    #[rustc_const_unstable(feature = "const_maybe_uninit_array_assume_init", issue = "96097")]
-    #[inline(always)]
-    #[track_caller]
-    pub const unsafe fn array_assume_init<const N: usize>(array: [Self; N]) -> [T; N] {


Like I've mentioned in some other PRs, I'm not willing to take an API removal (even an unstable one) without libs-api team oversight.

Up to you if you want to bring this up in an ACP to see if T-libs-api agrees, or if you want to make this just a T-libs change that updates the implementations of things to use transpose without actually removing things.

@rustbot author

Nah, I want to get rid of these. Created rust-lang/libs-team#122

Actually, this is probably what you were trying to tell me but I think it'll be easier to split stdlib usage removal from api removal, so I'll pull out the usage removals.

Yup, it's always easiest to split things up by decision makers.

Such as, where possible:

changes to compiler separate from library

additions separate from removals

internal details separate from anything impacting callers

Haha yeah, thanks. I feel like I've learned this lesson at least a dozen times by now, but the initial ease of piling a bunch of crap together is too good a fool. :)

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>

rust-log-analyzer · 2022-10-17T19:22:31Z

The job x86_64-gnu-llvm-13 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

…=scottmcm Remove all uses of array_assume_init See rust-lang#103134 (comment) r? `@scottmcm`

scottmcm · 2023-01-14T01:43:56Z

Waiting on ACP in rust-lang/libs-team#122 -- libs-api indicated that transpose isn't their preferred direction, which might well affect this.

Remove all uses of array_assume_init See rust-lang/rust#103134 (comment) r? `@scottmcm`

bors · 2023-02-13T13:50:36Z

☔ The latest upstream changes (presumably #107634) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive assigned scottmcm Oct 17, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 17, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2022

This comment has been minimized.

Sign in to view

SUPERCILEX force-pushed the uninit-array-assume branch from eb99568 to 8820c89 Compare October 17, 2022 04:52

This comment has been minimized.

Sign in to view

Noratrieb reviewed Oct 17, 2022

View reviewed changes

library/core/src/mem/maybe_uninit.rs Show resolved Hide resolved

Noratrieb reviewed Oct 17, 2022

View reviewed changes

scottmcm reviewed Oct 17, 2022

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2022

Kill array_assume_init

8e68496

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>

SUPERCILEX force-pushed the uninit-array-assume branch from 8820c89 to 8e68496 Compare October 17, 2022 19:17

SUPERCILEX mentioned this pull request Oct 17, 2022

Revamp unstable MaybeUninit APIs rust-lang/libs-team#122

Open

SUPERCILEX mentioned this pull request Oct 17, 2022

Remove all uses of array_assume_init #103163

Merged

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 18, 2022

Rollup merge of rust-lang#103163 - SUPERCILEX:uninit-array-assume2, r…

b411b88

…=scottmcm Remove all uses of array_assume_init See rust-lang#103134 (comment) r? `@scottmcm`

Dylan-DPC added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2022

thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Feb 10, 2023

Rollup merge of #103163 - SUPERCILEX:uninit-array-assume2, r=scottmcm

412f6f8

Remove all uses of array_assume_init See rust-lang/rust#103134 (comment) r? `@scottmcm`

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 13, 2023

JohnCSimon added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Apr 30, 2023

Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kill array_assume_init #103134

Kill array_assume_init #103134

SUPERCILEX commented Oct 17, 2022

rustbot commented Oct 17, 2022

This comment has been minimized.

This comment has been minimized.

SUPERCILEX commented Oct 17, 2022

Noratrieb Oct 17, 2022

SUPERCILEX Oct 17, 2022

Noratrieb Oct 17, 2022

SUPERCILEX Oct 17, 2022

scottmcm Oct 17, 2022

SUPERCILEX Oct 17, 2022

SUPERCILEX Oct 17, 2022

scottmcm Oct 18, 2022

SUPERCILEX Oct 18, 2022

rust-log-analyzer commented Oct 17, 2022

scottmcm commented Jan 14, 2023

bors commented Feb 13, 2023

Kill array_assume_init #103134

Are you sure you want to change the base?

Kill array_assume_init #103134

Conversation

SUPERCILEX commented Oct 17, 2022

rustbot commented Oct 17, 2022

This comment has been minimized.

This comment has been minimized.

SUPERCILEX commented Oct 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rust-log-analyzer commented Oct 17, 2022

scottmcm commented Jan 14, 2023

bors commented Feb 13, 2023