Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#102929) Implement String::leak (attempt 2) #103280

Merged
merged 2 commits into from
Oct 22, 2022
Merged

(#102929) Implement String::leak (attempt 2) #103280

merged 2 commits into from
Oct 22, 2022

Conversation

finnbear
Copy link
Contributor

@finnbear finnbear commented Oct 20, 2022 •
edited
Loading

Implementation of String::leak (#102929)

ACP: rust-lang/libs-team#109

Supersedes #102941 (see previous reviews there)

@rustbot label +T-libs-api -T-libs

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 20, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Oct 20, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2022
@finnbear finnbear mentioned this pull request Oct 20, 2022
Closed
@finnbear
Copy link
Contributor Author

@rustbot label -T-libs

@rustbot rustbot removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 20, 2022
@finnbear finnbear mentioned this pull request Oct 20, 2022
Closed
4 tasks
@finnbear finnbear changed the title (#102929) Implement String:leak (attempt 2) (#102929) Implement String::leak (attempt 2) Oct 20, 2022
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2022

📌 Commit 4f44d62 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 22, 2022
@Dylan-DPC
Rollup merge of rust-lang#103280 - finnbear:impl_string_leak_2, r=jos…
9e8a564 
…htriplett

(rust-lang#102929) Implement `String::leak` (attempt 2)

Implementation of `String::leak` (rust-lang#102929)

ACP: rust-lang/libs-team#109

Supersedes rust-lang#102941 (see previous reviews there)

`@rustbot` label +T-libs-api -T-libs
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 22, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 22, 2022
@Dylan-DPC
Rollup merge of rust-lang#103280 - finnbear:impl_string_leak_2, r=jos…
9dec95d 
…htriplett

(rust-lang#102929) Implement `String::leak` (attempt 2)

Implementation of `String::leak` (rust-lang#102929)

ACP: rust-lang/libs-team#109

Supersedes rust-lang#102941 (see previous reviews there)

``@rustbot`` label +T-libs-api -T-libs
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 22, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 22, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2022
@bors
Auto merge of rust-lang#103398 - Dylan-DPC:rollup-cj6w00o, r=Dylan-DPC
289b2b8 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#102602 (Slightly tweak comments wrt `lint_overflowing_range_endpoint`)
 - rust-lang#103190 (rustdoc: render bounds of cross-crate GAT params)
 - rust-lang#103224 (Allow semicolon after closure within parentheses in macros)
 - rust-lang#103280 ((rust-lang#102929) Implement `String::leak` (attempt 2))
 - rust-lang#103329 (Add a forgotten check for NonNull::new_unchecked's precondition)
 - rust-lang#103346 (Adjust argument type for mutable with_metadata_of (rust-lang#75091))
 - rust-lang#103360 (Reduce false positives in msys2 detection)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 141478b into rust-lang:master Oct 22, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 22, 2022
@finnbear finnbear mentioned this pull request Oct 22, 2022
Merged
notriddle added a commit to notriddle/rust that referenced this pull request Oct 22, 2022
@notriddle
Rollup merge of rust-lang#103412 - finnbear:fix_docs_typo_string_leak…
65e0bd0 
…, r=thomcc

Fix typo in docs of `String::leak`.

I introduced a typo in rust-lang#103280, this PR fixes it.

See rust-lang#103280 (comment)
notriddle added a commit to notriddle/rust that referenced this pull request Oct 22, 2022
@notriddle
Rollup merge of rust-lang#103412 - finnbear:fix_docs_typo_string_leak…
cbfc235 
…, r=thomcc

Fix typo in docs of `String::leak`.

I introduced a typo in rust-lang#103280, this PR fixes it.

See rust-lang#103280 (comment)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 22, 2022
@JohnTitor
Rollup merge of rust-lang#103412 - finnbear:fix_docs_typo_string_leak…
12874e3 
…, r=thomcc

Fix typo in docs of `String::leak`.

I introduced a typo in rust-lang#103280, this PR fixes it.

See rust-lang#103280 (comment)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 23, 2022
@matthiaskrgr
Rollup merge of rust-lang#103412 - finnbear:fix_docs_typo_string_leak…
25e02d6 
…, r=thomcc

Fix typo in docs of `String::leak`.

I introduced a typo in rust-lang#103280, this PR fixes it.

See rust-lang#103280 (comment)
@est31 est31 mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mati865 mati865 mati865 left review comments

@faptc faptc faptc left review comments

Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@finnbear @rustbot @rust-highfive @joshtriplett @bors @mati865 @faptc