-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark std::os::wasi::io::AsFd
etc. as stable.
#103308
Mark std::os::wasi::io::AsFd
etc. as stable.
#103308
Conversation
io_safety was stabilized in Rust 1.63, so mark the io_safety exports in `std::os::wasi::io` as stable. Fixes rust-lang#103306.
(rust-highfive has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This probably should also be beta (and stable?) nominated, so doing that now. |
@bors r+ p=2 |
library/std/src/os/wasi/io/mod.rs
Outdated
@@ -2,5 +2,5 @@ | |||
|
|||
#![unstable(feature = "wasi_ext", issue = "71213")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you also need the module itself to be stable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right. Fixed now.
@bors r+ p=2 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b1ab3b7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
This briefly came up in the libs meeting today: https://rust-lang.zulipchat.com/#narrow/stream/259402-t-libs.2Fmeetings/topic/Meeting.202022-10-26/near/306260701 We're fine with backporting it to 1.65.0 (which is released in eight days from now), but it'd be good if this says |
…mulacrum [beta] backport rollup * poll_fn and Unpin: fix pinning rust-lang#102737 * Support raw-dylib functions being used inside inlined functions rust-lang#102988 * Fix line numbers for MIR inlined code rust-lang#103071 * Add architectures to fn create_object_file rust-lang#103240 * Add eval hack in super_relate_consts back rust-lang#103279 * Mark std::os::wasi::io::AsFd etc. as stable. rust-lang#103308 * Truncate thread names on Linux and Apple targets rust-lang#103379 * Do not consider repeated lifetime params for elision. rust-lang#103450 * rustdoc: add missing URL redirect rust-lang#103588 * Remove commit_if_ok probe from NLL type relation rust-lang#103601 Also includes a copy of the release notes. r? `@ghost`
…ized, r=JohnTitor Adjust stabilization version to 1.65.0 for wasi fds See rust-lang#103308 (comment) for this ask. Backport of that PR to beta (1.65.0) will include a similar patch.
…ohnTitor Adjust stabilization version to 1.65.0 for wasi fds See rust-lang/rust#103308 (comment) for this ask. Backport of that PR to beta (1.65.0) will include a similar patch.
io_safety was stabilized in Rust 1.63, so mark the io_safety exports in
std::os::wasi::io
as stable.Fixes #103306.