Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for issue 98634 #103342

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Add test for issue 98634 #103342

merged 1 commit into from
Oct 29, 2022

Conversation

Rageking8
Copy link
Contributor

Fixes #98634

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 21, 2022
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2022
@rust-log-analyzer

This comment has been minimized.

@Rageking8
Copy link
Contributor Author

How do I add tokio as a dep for this test?

@Rageking8
Copy link
Contributor Author

In other words, how do I make this test work?

@Rageking8
Copy link
Contributor Author

r? @compiler-errors

src/test/ui/async-await/issue-98634.rs Outdated Show resolved Hide resolved
src/test/ui/async-await/issue-98634.rs Outdated Show resolved Hide resolved
@Rageking8
Copy link
Contributor Author

Should be good now if I never mess up something else. @compiler-errors Thanks a bunch for your quick help and review.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 28, 2022

📌 Commit 92b314b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 28, 2022
…, r=compiler-errors

Add test for issue 98634

Fixes rust-lang#98634
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 28, 2022
…, r=compiler-errors

Add test for issue 98634

Fixes rust-lang#98634
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 29, 2022
…, r=compiler-errors

Add test for issue 98634

Fixes rust-lang#98634
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2022
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#102961 (Make `CStr::from_ptr` `const`.)
 - rust-lang#103342 (Add test for issue 98634)
 - rust-lang#103383 (Note scope of TAIT more accurately)
 - rust-lang#103656 (Specialize ToString for Symbol)
 - rust-lang#103663 (rustdoc: remove redundant CSS/DOM `div.search-container`)
 - rust-lang#103664 (rustdoc-json-types: Improve ItemSummary::path docs)
 - rust-lang#103704 (Add a test for TAIT used with impl/dyn Trait inside RPIT)

Failed merges:

 - rust-lang#103618 (Rename some `OwnerId` fields.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 67c469f into rust-lang:master Oct 29, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 29, 2022
@Rageking8 Rageking8 deleted the add-test-for-issue-98634 branch October 31, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler error when an async function is store in a async struct
7 participants