Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #103344

Merged
merged 20 commits into from
Oct 21, 2022
Merged

Rollup of 6 pull requests #103344

merged 20 commits into from
Oct 21, 2022

Commits on Oct 16, 2022

  1. Configuration menu
    Copy the full SHA
    6d947e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4bbb163 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. macros: support doc comments in diag derives

    Documentation comments shouldn't affect the diagnostic derive in any
    way, but explicit support has to be added for ignoring the `doc`
    attribute.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    7fbaf27 View commit details
    Browse the repository at this point in the history
  2. macros: allow subdiagnostic-kind-less variants

    Sometimes it is convenient to return a subdiagnostic enum where one or
    more of the variants don't add anything to the diagnostic.
    
    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    1045e69 View commit details
    Browse the repository at this point in the history
  3. macros: fully specify path to Fn

    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    feeeb11 View commit details
    Browse the repository at this point in the history
  4. ast_lowering: use derive more

    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    2a4b587 View commit details
    Browse the repository at this point in the history
  5. ast_passes: use derive more

    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    ea5d258 View commit details
    Browse the repository at this point in the history
  6. lint: use derive more

    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    21d3bbd View commit details
    Browse the repository at this point in the history
  7. session: use derive more

    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    f8b628b View commit details
    Browse the repository at this point in the history
  8. infer: use derive more

    Signed-off-by: David Wood <david.wood@huawei.com>
    davidtwco committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    913f597 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Configuration menu
    Copy the full SHA
    f8e157b View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Configuration menu
    Copy the full SHA
    28d0312 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8509819 View commit details
    Browse the repository at this point in the history
  3. rustdoc: improve appearance of source page navigation bar

    This commit changes things so that the search bar is exactly centered between
    the top of the page and the top of the source code content area.
    notriddle committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    f6dd470 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Rollup merge of rust-lang#102287 - compiler-errors:unused-must-use-al…

    …so-supertrait, r=fee1-dead
    
    Elaborate supertrait bounds when triggering `unused_must_use` on `impl Trait`
    
    Given `impl Trait`, if one of its supertraits has a `#[must_use]`, then trigger the lint. This means that, for example, `-> impl ExactSizeIterator` also triggers the `must_use` on `trait Iterator`, which fixes rust-lang#102183.
    
    This might need `@rust-lang/lang` sign-off, since it changes the behavior of the lint, so cc'ing them.
    Dylan-DPC committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    66d91d8 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#102922 - kper:bugfix/102902-filtering-json,…

    … r=oli-obk
    
    Filtering spans when emitting json
    
    According to the issue rust-lang#102902, we shouldn't emit spans which have an empty span and no suggested replacement.
    Dylan-DPC committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    0a0e9f7 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#103051 - davidtwco:translation-tidying-up, …

    …r=compiler-errors
    
    translation: doc comments with derives, subdiagnostic-less enum variants, more derive use
    
    - Adds support for `doc` attributes in the diagnostic derives so that documentation comments don't result in the derive failing.
    - Adds support for enum variants in the subdiagnostic derive to not actually correspond to an addition to a diagnostic.
    - Made use of the derive in more places in the `rustc_ast_lowering`, `rustc_ast_passes`, `rustc_lint`, `rustc_session`, `rustc_infer` - taking advantage of recent additions like eager subdiagnostics, multispan suggestions, etc.
    
    cc rust-lang#100717
    Dylan-DPC committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    e11511d View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#103111 - cjgillot:shadow-label, r=estebank

    Account for hygiene in typo suggestions, and use them to point to shadowed names
    
    Fixes rust-lang#97459
    
    r? `@estebank`
    Dylan-DPC committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    41a1cfd View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#103260 - cuviper:needs-asm-support, r=fee1-…

    …dead
    
    Fixup a few tests needing asm support
    Dylan-DPC committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    3055eb9 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#103321 - notriddle:notriddle/source-page-to…

    …p-bar-layout, r=GuillaumeGomez
    
    rustdoc: improve appearance of source page navigation bar
    
    This commit changes things so that the search bar is exactly centered between the top of the page and the top of the source code content area.
    
    Preview: https://notriddle.com/notriddle-rustdoc-demos/source-page-header/src/std/lib.rs.html
    
    ## Before
    
    ![image](https://user-images.githubusercontent.com/1593513/197053420-02a64627-48ed-4bb6-9363-a1863d47b092.png)
    
    ## After
    
    ![image](https://user-images.githubusercontent.com/1593513/197053355-bd6149f9-0f5c-47da-aeb7-590b5eecb5da.png)
    Dylan-DPC committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    325e920 View commit details
    Browse the repository at this point in the history