-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
long error explanation for E0313 #103433
long error explanation for E0313 #103433
Conversation
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
Some changes occurred in diagnostic error codes |
Formatting looks good to me, thanks! I'll let someone else confirm the content of the explanation. |
Great, thank you! |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@GuillaumeGomez it seems like, according to the error log, that |
It's still produced by the compiler here. The difficult part of writing error explanation is to be able to actually trigger the error. In this case, you have the full control of the erroneous code example you write. ;) |
Correct. I explained my situation here to other contributors and maintainers on the Rust community Discord server and they suggested that deprecation of the error code might be the proper solution. The issue you referenced explains a bit more. If deprecation is decided upon, then this PR will no longer have significance. |
☔ The latest upstream changes (presumably #105940) made this pull request unmergeable. Please resolve the merge conflicts. |
@akabinds I believe that this can now be closed, |
…errors remove unreachable error code `E0313` Fixes rust-lang#103742 Makes rust-lang#103433 redundant Implements removal of `E0313`. I agree with the linked issue that this error code is unreachable but if someone could confirm that would be great, are crater runs done for this sort of thing? Also removed a redundant `// ignore-tidy-filelength` that I found while reading code. cc `@GuillaumeGomez` rust-lang#61137
…errors remove unreachable error code `E0313` Fixes rust-lang#103742 Makes rust-lang#103433 redundant Implements removal of `E0313`. I agree with the linked issue that this error code is unreachable but if someone could confirm that would be great, are crater runs done for this sort of thing? Also removed a redundant `// ignore-tidy-filelength` that I found while reading code. cc ``@GuillaumeGomez`` rust-lang#61137
Great. Thank you! |
part of #61137