-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stdio in UWP apps #103637
Use stdio in UWP apps #103637
Conversation
r? @ChrisDenton (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? thomcc |
This comment has been minimized.
This comment has been minimized.
Oh lol, I check on uwp but not on non-uwp. |
acadc30
to
363d7bd
Compare
This comment has been minimized.
This comment has been minimized.
What version of Windows do we require for UWP? |
Eh, we don't. It's a tier 3 target with nobody really responsible for it. |
This has been supported since Windows 10.0.16299. See https://learn.microsoft.com/en-us/uwp/win32-and-com/win32-apis#apis-from-api-ms-win-core-console-l1-1-0dll
363d7bd
to
5857c30
Compare
Oh, it is tier 3. I thought it was 2 for some reason. |
So, this extremely owns, and it's great to clean up that cruft. I'm a bit hesitant about deciding to change the supported version of UWP without any other sign-off. Do we have any idea what the supported version was before this? |
I don't think the supported version was ever defined. It was added way before the current target tier policy. I think its continued support relies on it either being low maintenance or some people coming along who are committing to support a UWP target (which is increasingly unlikely since the reports of its demise). Windows 10 1709 (which is what SDK 10.0.16299 targets) is already out of support so I personally don't think we should worry about it for a tier 3 target. Though if you'd rather this be discussed more widely within libs or other teams I'm certainly not opposed. |
Hm, seems fair to me. Tier 3 target where we never defined the official support and the new version is still old enough that the OS vendor no longer supports it seems unlikely to cause issues. This simplifies the code a lot, which is really worthwhile for a target like that. @bors r+ |
…earth Rollup of 8 pull requests Successful merges: - rust-lang#103072 (compiletest: set the dylib path when gathering target cfg) - rust-lang#103084 (Derive `Eq` and `Hash` for `ControlFlow`) - rust-lang#103575 (Change #[suggestion_*] attributes to use style="...") - rust-lang#103637 (Use stdio in UWP apps) - rust-lang#103638 (Add `multivalue` target feature to WASM target) - rust-lang#103781 (Detect unused files in `src/test/mir-opt` and error on them in tidy.) - rust-lang#103837 (Migrate sidebar-links-color GUI test to functions) - rust-lang#103839 (Print valid `--print` requests if request is invalid) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #103233
This has been supported since Windows 10.0.16299. See https://learn.microsoft.com/en-us/uwp/win32-and-com/win32-apis#apis-from-api-ms-win-core-console-l1-1-0dll