Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stdio in UWP apps #103637

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Use stdio in UWP apps #103637

merged 1 commit into from
Nov 2, 2022

Conversation

ChrisDenton
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2022

r? @ChrisDenton

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 27, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@ChrisDenton
Copy link
Member Author

r? thomcc

@rustbot rustbot assigned thomcc and unassigned ChrisDenton Oct 27, 2022
@rust-log-analyzer

This comment has been minimized.

@ChrisDenton
Copy link
Member Author

Oh lol, I check on uwp but not on non-uwp.

@rust-log-analyzer

This comment has been minimized.

@thomcc
Copy link
Member

thomcc commented Oct 27, 2022

What version of Windows do we require for UWP?

@ChrisDenton
Copy link
Member Author

Eh, we don't. It's a tier 3 target with nobody really responsible for it.

@thomcc
Copy link
Member

thomcc commented Oct 27, 2022

Oh, it is tier 3. I thought it was 2 for some reason.

@thomcc
Copy link
Member

thomcc commented Oct 27, 2022

So, this extremely owns, and it's great to clean up that cruft. I'm a bit hesitant about deciding to change the supported version of UWP without any other sign-off. Do we have any idea what the supported version was before this?

@ChrisDenton
Copy link
Member Author

I don't think the supported version was ever defined. It was added way before the current target tier policy. I think its continued support relies on it either being low maintenance or some people coming along who are committing to support a UWP target (which is increasingly unlikely since the reports of its demise). Windows 10 1709 (which is what SDK 10.0.16299 targets) is already out of support so I personally don't think we should worry about it for a tier 3 target.

Though if you'd rather this be discussed more widely within libs or other teams I'm certainly not opposed.

@thomcc
Copy link
Member

thomcc commented Nov 1, 2022

Hm, seems fair to me. Tier 3 target where we never defined the official support and the new version is still old enough that the OS vendor no longer supports it seems unlikely to cause issues. This simplifies the code a lot, which is really worthwhile for a target like that.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2022

📌 Commit 5857c30 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2022
…earth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#103072 (compiletest: set the dylib path when gathering target cfg)
 - rust-lang#103084 (Derive `Eq` and `Hash` for `ControlFlow`)
 - rust-lang#103575 (Change #[suggestion_*] attributes to use style="...")
 - rust-lang#103637 (Use stdio in UWP apps)
 - rust-lang#103638 (Add `multivalue` target feature to WASM target)
 - rust-lang#103781 (Detect unused files in `src/test/mir-opt` and error on them in tidy.)
 - rust-lang#103837 (Migrate sidebar-links-color GUI test to functions)
 - rust-lang#103839 (Print valid `--print` requests if request is invalid)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 65d63ca into rust-lang:master Nov 2, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 2, 2022
@ChrisDenton ChrisDenton deleted the stdio-uwp branch November 2, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std lib compile errors for uwp-windows-msvc targets
5 participants