-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Identity
lang item
#103985
Add Identity
lang item
#103985
Conversation
This comment has been minimized.
This comment has been minimized.
9a0192c
to
9ae1b86
Compare
I added the missing "explanation" for the ignored code block in the documentation. |
This comment has been minimized.
This comment has been minimized.
Wait...why? |
🤣 this is missing like 112% of the context. The linked PR is a huge task it seems and I wanted @GuillaumeGomez to check if the problem is that we don't normalize in enough places or whether it's just the linked PR missing a normalization for the new type alias variant wherever we normalize projections. If this pr passes, then the linked PR should be trivial instead of adding normalization to a billion places. If this PR fails, then we can build tests that fail on master by doing the same thing as what this PR does just without a lang item and contained to a single test |
9ae1b86
to
005ba9c
Compare
Everything falls apart as soon as we run outside of bootstrap because it doesn't seem to be able to find the |
005ba9c
to
d1c3003
Compare
d1c3003
to
a0aeed0
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #104321) made this pull request unmergeable. Please resolve the merge conflicts. |
f51abc6
to
f51255f
Compare
This comment has been minimized.
This comment has been minimized.
66c0c63
to
61ce752
Compare
…field-ty, r=oli-obk Add missing normalization for union fields types Overshadows rust-lang#106808. From the experiment rust-lang#103985. In short, it allows to use projections as a type for union's fields. cc `@compiler-errors` r? `@oli-obk`
…aliases behind an env variable
61ce752
to
cae3242
Compare
cae3242
to
fc334ce
Compare
… r=oli-obk Add missing normalization for union fields types Overshadows rust-lang/rust#106808. From the experiment rust-lang/rust#103985. In short, it allows to use projections as a type for union's fields. cc `@compiler-errors` r? `@oli-obk`
☔ The latest upstream changes (presumably #104833) made this pull request unmergeable. Please resolve the merge conflicts. |
Superseded by #108860 if I understand correctly. Closing as completed. Feel free to reopen if you disagree. |
This is another approach for #97974 suggested by @oli-obk.
The plan with this is then to add the
TyAlias
variant into the rustc_type_irTyKind
enum.cc @compiler-errors
r? @oli-obk