Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclusive nits #104057

Closed
wants to merge 1 commit into from
Closed

Exclusive nits #104057

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 6, 2022

Tracking issue: #98407

  • const fns now have rustc_const_unstable
  • Added Generator forwarding impl
  • Added FnOnce & FnMut forwarding impls
  • Made the From impl unstably const

Exclusive nits
dd7f657 
Tracking issue: #98407
- const fns now have `rustc_const_unstable`
- Added `Generator` forwarding impl
- Added `FnOnce` & `FnMut` forwarding impls
- Made the `From` impl unstably const
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2022

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 6, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@ghost ghost mentioned this pull request Nov 6, 2022
Open
5 tasks
@ghost
Copy link
Author

ghost commented Nov 6, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 6, 2022
@bors
Copy link
Contributor

bors commented Nov 19, 2022

☔ The latest upstream changes (presumably #102795) made this pull request unmergeable. Please resolve the merge conflicts.

@anden3 anden3 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2023
@anden3
Copy link
Contributor

anden3 commented Apr 13, 2023

Hello @h4x5! I noticed that there are some merge conflicts for this PR, what's the status of it?

@ghost
Copy link
Author

ghost commented Apr 17, 2023

@anden3 I can resolve the conflicts if a reviewer is interested in merging this

@anden3
Copy link
Contributor

anden3 commented Apr 17, 2023

@h4x5 I believe one of the preconditions for getting a review is to not have merge conflicts, so it's probably much easier if you fix those first.

@Dylan-DPC
Copy link
Member

@h4x5

I can resolve the conflicts if a reviewer is interested in merging this

it would be easier to resolve the conflicts, and then wait for the reviewer to review it when they have the time to.

@bjorn3
Copy link
Member

bjorn3 commented Apr 22, 2023

Made the From impl unstably const

#110393 removed all const impls to make it easier to change the way const traits work. Please don't add new const impls for now.

@JohnCSimon
Copy link
Member

@h4x5
ping from triage - can you post your status on this PR? There hasn't been an update in a few months. Thanks!

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@dtolnay dtolnay assigned dtolnay and unassigned joshtriplett Sep 17, 2023
dtolnay
dtolnay requested changes Sep 17, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #104057 (comment), I don't think the impl<T> const From<T> for Exclusive<T> is something we would accept for now.

The rest of the PR looks good to me.

@ghost ghost closed this by deleting the head repository Sep 28, 2023
@dtolnay dtolnay mentioned this pull request Sep 28, 2023
Merged
@dtolnay
Copy link
Member

dtolnay commented Sep 28, 2023

I have extracted the FnOnce, FnMut, Generator part of this PR to #116241.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 29, 2023
@matthiaskrgr
Rollup merge of rust-lang#116241 - dtolnay:exclusivefwd, r=Amanieu
4db2b74 
Add Exclusive forwarding impls (FnOnce, FnMut, Generator)

This is adapted from rust-lang#104057.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2023
@rust-timer
Unrolled build for rust-lang#116241
4501f7b 
Rollup merge of rust-lang#116241 - dtolnay:exclusivefwd, r=Amanieu

Add Exclusive forwarding impls (FnOnce, FnMut, Generator)

This is adapted from rust-lang#104057.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dtolnay dtolnay

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rustbot @bors @anden3 @Dylan-DPC @bjorn3 @JohnCSimon @dtolnay @joshtriplett