-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match and enforce crate and slug names #104120
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eholk (or someone else) soon. Please see the contribution instructions for more information. |
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
This comment has been minimized.
This comment has been minimized.
r? @davidtwco |
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bors r+ |
📌 Commit edeb64d964447ea8b3a5c51086f557b332be9054 has been approved by It is now in the queue for this repository. |
This comment was marked as resolved.
This comment was marked as resolved.
rebased @rustbot ready |
@bors r+ |
📌 Commit fdb953c5870e2fad5c241cbbf6bb7e05c71a2f65 has been approved by It is now in the queue for this repository. |
@bors r+ |
📌 Commit ce1e031468946981db716b0ded30a8ce803140a1 has been approved by It is now in the queue for this repository. |
This comment was marked as resolved.
This comment was marked as resolved.
Can this get some priority? I fear I'll be rebasing until the end of days otherwise @rustbot ready |
☔ The latest upstream changes (presumably #104655) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors p=1 |
I had to rebase first 😅 @rustbot ready |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b7bc90f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. |
Some of these were in the wrong place or had a name that didn't match.