linker: Preserve relative order of -l options, including dynamic libs
#104406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamic libraries pulled through dependency crates are no longer linked last, they are now linked immediately after their corresponding crates, like other libraries
rustbot
added
S-waiting-on-review
|
I think this change itself looks good. I'm not comfortable approving it though as it is a breaking change. |
petrochenkov
added
S-waiting-on-author
|
@petrochenkov Can you please post your status on this PR? It has sat idle for months. |
|
I need to analyze the regressions in |
|
I'll continue this work when I have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic native libraries pulled through dependency crates are no longer linked last, they are now linked immediately after their corresponding crates, like other libraries.
The change is a part of RFC 2951 "Linking modifiers for native libraries" (https://github.com/rust-lang/rfcs/blob/master/text/2951-native-link-modifiers.md#relative-order-of--l-and--clink-args-options, #99427).
Crater run with this change found some regressions, their analysis can be found in #102832 (comment).
There are 3 root regressions, in all cases crates depend on some native libraries, but do not declare that dependency.
This is a continuation of #103311 and the second part of #102832.
r? @bjorn3
TODO:
Create issues/PRs for the affected crateshttps://gitlab.com/taricorp/llvm-sys.rs/-/issues/41 Discuss external linking and linking order blas-lapack-rs/lapacke-sys#2 This crate depends on libc, but doesn't declare that dependency purpleprotocol/mimalloc_rust#85