Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggest associated call syntax #104422

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
316 changes: 171 additions & 145 deletions compiler/rustc_hir_typeck/src/method/suggest.rs

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions src/test/ui/suggestions/dont-suggest-ufcs-for-const.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
fn main() {
1_u32.MAX();
//~^ ERROR no method named `MAX` found for type `u32` in the current scope
}
15 changes: 15 additions & 0 deletions src/test/ui/suggestions/dont-suggest-ufcs-for-const.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
error[E0599]: no method named `MAX` found for type `u32` in the current scope
--> $DIR/dont-suggest-ufcs-for-const.rs:2:11
|
LL | 1_u32.MAX();
| ------^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `u32::MAX()`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should filter out this suggestion... but I'll file a follow-up for someone who would like to dive deeper into method candidate assembly...

|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
= note: the candidate is defined in an impl for the type `u32`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
15 changes: 15 additions & 0 deletions src/test/ui/suggestions/suggest-assoc-fn-call-deref.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// run-rustfix

#![allow(unused)]

struct Foo<T>(T);

impl<T> Foo<T> {
fn test() -> i32 { 1 }
}

fn main() {
let x = Box::new(Foo(1i32));
Foo::<i32>::test();
//~^ ERROR no method named `test` found for struct `Box<Foo<i32>>` in the current scope
}
15 changes: 15 additions & 0 deletions src/test/ui/suggestions/suggest-assoc-fn-call-deref.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// run-rustfix

#![allow(unused)]

struct Foo<T>(T);

impl<T> Foo<T> {
fn test() -> i32 { 1 }
}

fn main() {
let x = Box::new(Foo(1i32));
x.test();
//~^ ERROR no method named `test` found for struct `Box<Foo<i32>>` in the current scope
}
19 changes: 19 additions & 0 deletions src/test/ui/suggestions/suggest-assoc-fn-call-deref.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
error[E0599]: no method named `test` found for struct `Box<Foo<i32>>` in the current scope
--> $DIR/suggest-assoc-fn-call-deref.rs:13:7
|
LL | x.test();
| --^^^^--
| | |
| | this is an associated function, not a method
| help: use associated function syntax instead: `Foo::<i32>::test()`
|
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter
note: the candidate is defined in an impl for the type `Foo<T>`
--> $DIR/suggest-assoc-fn-call-deref.rs:8:5
|
LL | fn test() -> i32 { 1 }
| ^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.