-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix suggest associated call syntax #104422
Merged
bors
merged 4 commits into
rust-lang:master
from
compiler-errors:fix-suggest_associated_call_syntax
Nov 15, 2022
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
fn main() { | ||
1_u32.MAX(); | ||
//~^ ERROR no method named `MAX` found for type `u32` in the current scope | ||
} |
15 changes: 15 additions & 0 deletions
15
src/test/ui/suggestions/dont-suggest-ufcs-for-const.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
error[E0599]: no method named `MAX` found for type `u32` in the current scope | ||
--> $DIR/dont-suggest-ufcs-for-const.rs:2:11 | ||
| | ||
LL | 1_u32.MAX(); | ||
| ------^^^-- | ||
| | | | ||
| | this is an associated function, not a method | ||
| help: use associated function syntax instead: `u32::MAX()` | ||
| | ||
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter | ||
= note: the candidate is defined in an impl for the type `u32` | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0599`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// run-rustfix | ||
|
||
#![allow(unused)] | ||
|
||
struct Foo<T>(T); | ||
|
||
impl<T> Foo<T> { | ||
fn test() -> i32 { 1 } | ||
} | ||
|
||
fn main() { | ||
let x = Box::new(Foo(1i32)); | ||
Foo::<i32>::test(); | ||
//~^ ERROR no method named `test` found for struct `Box<Foo<i32>>` in the current scope | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// run-rustfix | ||
|
||
#![allow(unused)] | ||
|
||
struct Foo<T>(T); | ||
|
||
impl<T> Foo<T> { | ||
fn test() -> i32 { 1 } | ||
} | ||
|
||
fn main() { | ||
let x = Box::new(Foo(1i32)); | ||
x.test(); | ||
//~^ ERROR no method named `test` found for struct `Box<Foo<i32>>` in the current scope | ||
} |
19 changes: 19 additions & 0 deletions
19
src/test/ui/suggestions/suggest-assoc-fn-call-deref.stderr
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
error[E0599]: no method named `test` found for struct `Box<Foo<i32>>` in the current scope | ||
--> $DIR/suggest-assoc-fn-call-deref.rs:13:7 | ||
| | ||
LL | x.test(); | ||
| --^^^^-- | ||
| | | | ||
| | this is an associated function, not a method | ||
| help: use associated function syntax instead: `Foo::<i32>::test()` | ||
| | ||
= note: found the following associated functions; to be used as methods, functions must have a `self` parameter | ||
note: the candidate is defined in an impl for the type `Foo<T>` | ||
--> $DIR/suggest-assoc-fn-call-deref.rs:8:5 | ||
| | ||
LL | fn test() -> i32 { 1 } | ||
| ^^^^^^^^^^^^^^^^ | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0599`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably should filter out this suggestion... but I'll file a follow-up for someone who would like to dive deeper into method candidate assembly...