Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #104738

Closed
wants to merge 49 commits into from
Closed

Commits on Nov 17, 2022

  1. Configuration menu
    Copy the full SHA
    aef3d93 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    83701f5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    23422a8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9864a63 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2022

  1. Refactor must_use lint into two parts

    Before, the lint did the checking for `must_use` and pretty printing the
    types in a special format in one pass, causing quite complex and
    untranslatable code.
    Now the collection and printing is split in two. That should also make
    it easier to translate or extract the type pretty printing in the
    future.
    
    Also fixes an integer overflow in the array length pluralization
    calculation.
    Noratrieb committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    4e9ceef View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. Configuration menu
    Copy the full SHA
    644a5a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f5addd View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. Configuration menu
    Copy the full SHA
    1a69666 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2752e32 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    94fe30f View commit details
    Browse the repository at this point in the history
  4. Add an always-ambiguous predicate to make sure that we don't accident…

    …lally allow trait resolution to prove false things during coherence
    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    ae80c76 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9cd44f8 View commit details
    Browse the repository at this point in the history
  6. Move a field around

    oli-obk committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    9a8e1ee View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f42e490 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    11ae334 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7301cd7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    11adf03 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c16a90f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    98cb7c8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    fface0c View commit details
    Browse the repository at this point in the history
  14. Fix clippy code

    estebank committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    cca960d View commit details
    Browse the repository at this point in the history
  15. Use type_implements_trait

    estebank committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    242dd83 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e88009b View commit details
    Browse the repository at this point in the history
  17. Remove logic duplication

    estebank committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    0994f8d View commit details
    Browse the repository at this point in the history
  18. Tweak output in for loops

    Do not suggest `.clone()` as we already suggest borrowing the iterated
    value.
    estebank committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    4918d4f View commit details
    Browse the repository at this point in the history
  19. Fix wording

    estebank committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    33a6dc9 View commit details
    Browse the repository at this point in the history
  20. Fix rustfmt

    estebank committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    6f77be4 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    a930d44 View commit details
    Browse the repository at this point in the history
  22. Fix rebase

    estebank committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    5bf1413 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    95a5beb View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    2698d24 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    9a39012 View commit details
    Browse the repository at this point in the history
  26. Account for closures

    estebank committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    7cc4fb5 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Configuration menu
    Copy the full SHA
    3099dfd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d5d692 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    04610ad View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b80356a View commit details
    Browse the repository at this point in the history
  5. Speed up mpsc_stress test

    mejrs committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    f2830f2 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#101368 - thomcc:wintls-noinline, r=ChrisDenton

    Forbid inlining `thread_local!`'s `__getit` function on Windows
    
    Sadly, this will make things slower to avoid UB in an edge case, but it seems hard to avoid... and really whenever I look at this code I can't help but think we're asking for trouble.
    
    It's pretty dodgy for us to leave this as a normal function rather than `#[inline(never)]`, given that if it *does* get inlined into a dynamically linked component, it's extremely unsafe (you get some other thread local, or if you're lucky, crash). Given that it's pretty rare for people to use dylibs on Windows, the fact that we haven't gotten bug reports about it isn't really that convincing. Ideally we'd come up with some kind of compiler solution (that avoids paying for this cost when static linking, or *at least* for use within the same crate...), but it's not clear what that looks like.
    
    Oh, and because all this is only needed when we're implementing `thread_local!` with `#[thread_local]`, this patch adjusts the `cfg_attr` to be `all(windows, target_thread_local)` as well.
    
    r? `@ChrisDenton`
    
    See also rust-lang#84933, which is about improving the situation.
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    90e8b94 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#102293 - ecnelises:aix.initial, r=davidtwco

    Add powerpc64-ibm-aix as Tier-3 target
    
    This is part of the effort mentioned in rust-lang/compiler-team#553.
    
    A reference to these options are definitions from [clang](https://github.com/llvm/llvm-project/blob/ad6fe32032a6229e0c40510e9bed419a01c695b3/clang/lib/Basic/Targets/PPC.h#L414-L448) and [llvm](https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/PowerPC/PPCTargetMachine.cpp).
    
    AIX has a system `ld` but [its options and behaviors](https://www.ibm.com/docs/en/aix/7.3?topic=l-ld-command) are different from GNU ld. Thanks to `@bzEq` for contributing the linking args.
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    ab6f755 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#103488 - oli-obk:impl_trait_for_tait, r=lcnr

    Allow opaque types in trait impl headers and rely on coherence to reject unsound cases
    
    r? `@lcnr`
    
    fixes rust-lang#99840
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    43eb708 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#103908 - estebank:consider-cloning, r=compi…

    …ler-errors
    
    Suggest `.clone()` or `ref binding` on E0382
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    b3a2eea View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#104359 - Nilstrieb:plus-one, r=fee1-dead

    Refactor must_use lint into two parts
    
    Before, the lint did the checking for `must_use` and pretty printing the types in a special format in one pass, causing quite complex and untranslatable code.
    Now the collection and printing is split in two. That should also make it easier to translate or extract the type pretty printing in the future.
    
    Also fixes an integer overflow in the array length pluralization
    calculation.
    
    fixes rust-lang#104352
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    1e12a3a View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#104509 - spastorino:use-obligation-ctxt, r=…

    …lcnr
    
    Use obligation ctxt instead of dyn TraitEngine
    
    r? `@lcnr`
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    bbe1843 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#104647 - RalfJung:alloc-strict-provenance, …

    …r=thomcc
    
    enable fuzzy_provenance_casts lint in liballoc and libstd
    
    r? `@thomcc`
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    7c56974 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#104717 - GuillaumeGomez:test-projection-use…

    …d-as-const-generic, r=oli-obk
    
    Add failing test for projections used as const generic
    
    Based on the experiment done in rust-lang#104443, we realized it's currently not possible to support projections in const generics. More information about it in rust-lang#104443 (comment).
    
    This PR adds the UI test in any case so we can gather data in order to work towards adding `TyAlias` into the ABI in the future.
    
    r? `@oli-obk`
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    e105d05 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    60a07e1 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#104724 - WaffleLapkin:to_def_idn't, r=compi…

    …ler-errors
    
    Fix `ClosureKind::to_def_id`
    
    `Fn` and `FnOnce` were mixed up in rust-lang#99131.
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    2078dbd View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#104728 - WaffleLapkin:require-lang-items-po…

    …litely, r=compiler-errors
    
    Use `tcx.require_lang_item` instead of unwrapping lang items
    
    I clearly remember esteban telling me that there is `require_lang_item` but he was from a phone atm and I couldn't find it, so I didn't use it. Stumbled on it today, so here we are :)
    Manishearth authored Nov 22, 2022
    Configuration menu
    Copy the full SHA
    0c626d4 View commit details
    Browse the repository at this point in the history