Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for item-local in inner scope for E0425 #104864

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Account for item-local in inner scope for E0425 #104864

merged 2 commits into from
Dec 13, 2022

Conversation

chenyukang
Copy link
Member

Fixes #104700

@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2022

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2022
@chenyukang
Copy link
Member Author

r? @estebank

@rustbot rustbot assigned estebank and unassigned oli-obk Nov 25, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2022

📌 Commit 68ea516 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 13, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2022
@bors
Auto merge of rust-lang#105644 - matthiaskrgr:rollup-qc6hlzq, r=matth…
b96d9e0 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104864 (Account for item-local in inner scope for E0425)
 - rust-lang#105332 (Point out the type of associated types in every method call of iterator chains)
 - rust-lang#105620 (Remove unnecessary uses of `clone`)
 - rust-lang#105625 (minor code cleanups)
 - rust-lang#105629 (rustdoc: stop treating everything in a trait item as a method)
 - rust-lang#105636 (Add check for local-storage value when changing "display line numbers" settings)
 - rust-lang#105639 (rustdoc: remove `type="text/css" from stylesheet links)
 - rust-lang#105640 (Adjust miri to still be optional)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6dbaf86 into rust-lang:master Dec 13, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Account for item-local, out of scope bindings, in E0425
6 participants
@chenyukang @rustbot @rust-log-analyzer @estebank @bors @oli-obk