Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify some binder shifting logic #104927

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Simplify some binder shifting logic #104927

merged 1 commit into from
Nov 28, 2022

Conversation

compiler-errors
Copy link
Member

Not sure if worth, but we'll see

@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2022

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 26, 2022
@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 26, 2022
@bors
Copy link
Contributor

bors commented Nov 26, 2022

⌛ Trying commit 61e185b with merge 8c7c6db45954fbe657460191f1719525a5aeb071...

@compiler-errors compiler-errors mentioned this pull request Nov 26, 2022
Closed
@bors
Copy link
Contributor

bors commented Nov 26, 2022

☀️ Try build successful - checks-actions
Build commit: 8c7c6db45954fbe657460191f1719525a5aeb071 (8c7c6db45954fbe657460191f1719525a5aeb071)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8c7c6db45954fbe657460191f1719525a5aeb071): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 26, 2022
@compiler-errors
Copy link
Member Author

Well, I still think this is worth landing, since it does make the code prettier.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 28, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 28, 2022

📌 Commit 61e185b has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Nov 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2022
@bors
Auto merge of rust-lang#105008 - Dylan-DPC:rollup-wcd19yu, r=Dylan-DPC
8a09420 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#104360 (Stabilize native library modifier `verbatim`)
 - rust-lang#104732 (Refactor `ty::ClosureKind` related stuff)
 - rust-lang#104795 (Change multiline span ASCII art visual order)
 - rust-lang#104890 (small method code cleanup)
 - rust-lang#104907 (Remove `SelectionContext::infcx()` in favor of field access)
 - rust-lang#104927 (Simplify some binder shifting logic)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d5de2a8 into rust-lang:master Nov 28, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 28, 2022
@compiler-errors compiler-errors deleted the binder-shifting-logic branch August 11, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @rust-timer @bors @oli-obk