-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #104983
Rollup of 8 pull requests #104983
Conversation
jruderman tried to add this in rust-lang#104916, for example. I think I've seen this happen before as well.
This commit fixes a few inconsistencies and erratic behavior from the notable traits, settings, and sidebar popups: * It makes it so that pressing Escape closes the mobile sidebar. This is a bit difficult to do on iPhone, but on other setups like desktop tiling window managers, it's easy and makes sense. * It makes sure that pressing escape while a notable trait popover is open focuses the popover's toggle button, instead of leaving nothing focused, since that makes more sense with keyboard navigation. Clicking the settings, help, or sidebar buttons, however, will not focus the notable trait popover toggle button. * It ensures that notable trait and settings popovers are exclusive with the mobile sidebar. Nothing should ever overlap a popover, and there should never be more than one popover open at once.
After removing `GenFuture`, I special-cased async generators to pretty-print as `impl Future<Output = X>` mainly to avoid too much diagnostics changes originally. This now reverses that change so that async fn/blocks are pretty-printed as `[$movability `async` $something@$source-position]` in various diagnostics, and updates the tests that this touches.
This will use rust_out.exe for doctests on Windows, rust_out.wasm for doctests in the wasm case, and also handles cross-compiling or user-provided targets.
…ddle Use `rust_out{exe_suffix}` for doctests This was mentioned as an issue to me by ````@bruxisma.```` There are 3 separate instances where "rust_out" can become part of the name of a Rust executable, so I am mostly just hoping that this fixes the problem, given that the other sites which it can slip in seem to be well-behaved.
notify lcnr on changes to `ObligationCtxt` Right now the `ObligationCtxt` has an API which should prevent leaking any important details of the trait solver. This allows us to freely use it without having to worry about causing issues for the [trait solver rewrite](https://github.com/orgs/rust-lang/projects/26/views/1). I would like to keep it this way ^^
Explain how to get the discriminant out of a `#[repr(T)] enum` with payload example stolen from rust-lang/reference#1055 ````@rustbot```` label A-docs
…ertions, r=Mark-Simulacrum Allow non-org members to label `requires-debug-assertions` `jruderman` tried to add this in rust-lang#104916, for example. I think I've seen this happen before as well.
Pretty-print generators with their `generator_kind` After removing `GenFuture`, I special-cased async generators to pretty-print as `impl Future<Output = X>` mainly to avoid too much diagnostics changes originally. This now reverses that change so that async fn/blocks are pretty-printed as `[$async-type@$source-position]` in various diagnostics, and updates the tests that this touches.
…homcc Remove redundant `all` in cfg This appears to have been accidentally left in after removing the other branches rust-lang@45bf1ed (hat tip to kangalioo for the git archaeology)
…ts, r=jyn514 Support unit tests for jsondoclint r? ````@ghost````
…ocus, r=GuillaumeGomez rustdoc: improve popover focus handling JS This commit fixes a few inconsistencies and erratic behavior from the notable traits, settings, and sidebar popups: * It makes it so that pressing Escape closes the mobile sidebar. This is a bit difficult to do on iPhone, but on other setups like desktop tiling window managers, it's easy and makes sense. * It makes sure that pressing escape while a notable trait popover is open focuses the popover's toggle button, instead of leaving nothing focused, since that makes more sense with keyboard navigation. Clicking the settings, help, or sidebar buttons, however, will not focus the notable trait popover toggle button. * It ensures that notable trait and settings popovers are exclusive with the mobile sidebar. Nothing should ever overlap a popover, and there should never be more than one popover open at once.
@bors r+ rollup=never p=8 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: 454784afba In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (1eb62b1): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
Successful merges:
rust_out{exe_suffix}
for doctests #95836 (Userust_out{exe_suffix}
for doctests)ObligationCtxt
#104882 (notify lcnr on changes toObligationCtxt
)#[repr(T)] enum
with payload #104892 (Explain how to get the discriminant out of a#[repr(T)] enum
with payload)requires-debug-assertions
#104917 (Allow non-org members to labelrequires-debug-assertions
)generator_kind
#104931 (Pretty-print generators with theirgenerator_kind
)all
in cfg #104934 (Remove redundantall
in cfg)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup