-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run patchelf also on rust-analyzer-proc-macro-srv. #105068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @jyn514 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 29, 2022
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 29, 2022
Thanks! @bors r+ rollup |
💡 This pull request was already approved, no need to approve it again.
|
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2022
…iaskrgr Rollup of 14 pull requests Successful merges: - rust-lang#103876 (type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds) - rust-lang#104427 (Explain why `rematch_impl` fails to be infallible) - rust-lang#104436 (Add slice to the stack allocated string comment) - rust-lang#104523 (Don't use periods in target names) - rust-lang#104627 (Print all features with --print target-features) - rust-lang#104911 (Make inferred_outlives_crate return Clause) - rust-lang#105002 (Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str`) - rust-lang#105023 (Statics used in reachable function's inline asm are reachable) - rust-lang#105045 (`rustc_ast_{passes,pretty}`: remove `ref` patterns) - rust-lang#105049 (Hermit: Minor build fixes) - rust-lang#105051 (Replace a macro with a function) - rust-lang#105062 (rustdoc: use shorthand background for rustdoc toggle CSS) - rust-lang#105066 (move `candidate_from_obligation` out of assembly) - rust-lang#105068 (Run patchelf also on rust-analyzer-proc-macro-srv.) Failed merges: - rust-lang#105050 (Remove useless borrows and derefs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On NixOS,
rust-analyzer-proc-macro-srv
needs to bepatchelf
ed just like all the other libs and binaries.With this fix, I am able to use the language server configuration recommended in the guide.