Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perf experiment] Use const_eval_select in ptr::is_null #105435

Closed
wants to merge 1 commit into from
Closed

[perf experiment] Use const_eval_select in ptr::is_null #105435

wants to merge 1 commit into from

Conversation

saethlin
Copy link
Member

@saethlin saethlin commented Dec 8, 2022

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2022
@saethlin
Copy link
Member Author

saethlin commented Dec 8, 2022

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2022
@bors
Copy link
Contributor

bors commented Dec 8, 2022

⌛ Trying commit 74fc6dadafcd0453f158f9ba8825b151471a991d with merge 7a8aa9d17f8af5dc8a00d7927ad7e2eb6e10237b...

@bors
Copy link
Contributor

bors commented Dec 8, 2022

☀️ Try build successful - checks-actions
Build commit: 7a8aa9d17f8af5dc8a00d7927ad7e2eb6e10237b (7a8aa9d17f8af5dc8a00d7927ad7e2eb6e10237b)

1 similar comment
@bors
Copy link
Contributor

bors commented Dec 8, 2022

☀️ Try build successful - checks-actions
Build commit: 7a8aa9d17f8af5dc8a00d7927ad7e2eb6e10237b (7a8aa9d17f8af5dc8a00d7927ad7e2eb6e10237b)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7a8aa9d17f8af5dc8a00d7927ad7e2eb6e10237b): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.9%, 0.9%] 3
Regressions ❌
(secondary)		 0.2% [0.2%, 0.2%] 4
Improvements ✅
(primary)		 -0.5% [-1.0%, -0.2%] 16
Improvements ✅
(secondary)		 -0.4% [-0.8%, -0.2%] 5
All ❌✅ (primary) -0.3% [-1.0%, 0.9%] 19

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.7% [2.4%, 3.0%] 4
Regressions ❌
(secondary)		 1.1% [1.1%, 1.1%] 1
Improvements ✅
(primary)		 -5.3% [-9.8%, -0.3%] 5
Improvements ✅
(secondary)		 -2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) -1.8% [-9.8%, 3.0%] 9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2022
@saethlin
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 10, 2022
@bors
Copy link
Contributor

bors commented Dec 10, 2022

⌛ Trying commit ab3e4e43518357336340d2d8e05a98fea507acbd with merge 47ba511c2f1883aee10603c182a9b361f2553954...

@bors
Copy link
Contributor

bors commented Dec 10, 2022

☀️ Try build successful - checks-actions
Build commit: 47ba511c2f1883aee10603c182a9b361f2553954 (47ba511c2f1883aee10603c182a9b361f2553954)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (47ba511c2f1883aee10603c182a9b361f2553954): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.9%, 1.1%] 3
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)		 -0.4% [-0.9%, -0.2%] 29
Improvements ✅
(secondary)		 -1.1% [-1.5%, -0.7%] 2
All ❌✅ (primary) -0.3% [-0.9%, 1.1%] 32

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.1% [1.4%, 2.8%] 5
Regressions ❌
(secondary)		 1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)		 -5.5% [-10.0%, -0.3%] 5
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.7% [-10.0%, 2.8%] 10

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 10, 2022
@saethlin saethlin mentioned this pull request Dec 28, 2022
Closed
@Noratrieb Noratrieb mentioned this pull request Dec 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 31, 2022
@bors
Auto merge of rust-lang#106275 - Nilstrieb:const-eval-select-me-some-…
dd01a16 
…compile-time, r=thomcc

Use some more `const_eval_select` in pointer methods for compile times

Builds on top of rust-lang#105435

`is_aligned_to` is _huge_ with calling `align_offset`, so this should cut it down a lot.

This shows up in rust-lang#65031 (comment)
@saethlin
Copy link
Member Author

Subsumed by #106275

@saethlin saethlin closed this Dec 31, 2022
@saethlin saethlin deleted the select-is-null branch December 31, 2022 18:55
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#106275 - Nilstrieb:const-eval-select-me-some-…
ba4304f 
…compile-time, r=thomcc

Use some more `const_eval_select` in pointer methods for compile times

Builds on top of rust-lang#105435

`is_aligned_to` is _huge_ with calling `align_offset`, so this should cut it down a lot.

This shows up in rust-lang#65031 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saethlin @rust-timer @bors @rustbot