Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcore: make result of iter::from_generator Clone #105526

Merged
merged 2 commits into from
Jan 15, 2023
Merged

libcore: make result of iter::from_generator Clone #105526

merged 2 commits into from
Jan 15, 2023

Conversation

Xiretza
Copy link
Contributor

@Xiretza Xiretza commented Dec 10, 2022

@rustbot label +A-generators

@Xiretza
libcore: make result type of iter::from_generator concrete
a8b5d4b 
This allows for propagating trait impls on the iterator type.
@Xiretza
libcore: make result of iter::from_generator Clone
17a0740 
This is currently only relevant with #![feature(generator_clone)].
@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2022

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the A-coroutines Area: Coroutines label Dec 10, 2022
@scottmcm
Copy link
Member

Generators like this are still experimental, so sure, seems fine. libs-api can talk about it later.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 14, 2023

📌 Commit 17a0740 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 14, 2023
@bors
Auto merge of rust-lang#106866 - matthiaskrgr:rollup-r063s44, r=matth…
afaf3e0 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105526 (libcore: make result of iter::from_generator Clone)
 - rust-lang#106563 (Fix `unused_braces` on generic const expr macro call)
 - rust-lang#106661 (Stop probing for statx unless necessary)
 - rust-lang#106820 (Deprioritize fulfillment errors that come from expansions.)
 - rust-lang#106828 (rustdoc: remove `docblock` class from notable trait popover)
 - rust-lang#106849 (Allocate one less vec while parsing arrays)
 - rust-lang#106855 (rustdoc: few small cleanups)
 - rust-lang#106860 (Remove various double spaces in the libraries.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 085d2f1 into rust-lang:master Jan 15, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
A-coroutines Area: Coroutines S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Xiretza @rustbot @scottmcm @bors