pidigits resurected #10555
Merged
pidigits resurected #10555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * default value when no args * license * removed libc printing * use extra::bigint instead of handmade gmp binding
bors
added a commit
that referenced
this pull request
Nov 18, 2013
Changes: * default value when no args * license * removed libc printing * use extra::bigint instead of handmade gmp binding The drawback is that it's 2 order of magnitude slower, the good news is that there is a good bench for extra::bigint.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
Ignore more type aliases in unnecessary_cast Fixes rust-lang#10555 changelog: [`unnecessary_cast`]: No longer lints cast from locals that are type aliases
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
Ignore more type aliases in `unnecessary_cast` This is potentially the worst code I've ever written, and even if not, it's very close to being on par with starb. This will ignore `call() as i32` and `local_obtained_from_call as i32` now. This should fix every reasonable way to reproduce rust-lang#10555, but likely not entirely. changelog: Ignore more type aliases in `unnecessary_cast`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The drawback is that it's 2 order of magnitude slower, the good news is that there is a good bench for extra::bigint.