Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug! with a better error message for failing Instance::resolve #105569

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

compiler-errors
Copy link
Member

Better ICE message when .unwrap().unwrap() fails.

@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2022

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 11, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2022

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@TaKO8Ki
Copy link
Member

TaKO8Ki commented Dec 12, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 12, 2022

📌 Commit bc293ed has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2022
…iaskrgr

Rollup of 2 pull requests

Successful merges:

 - rust-lang#104997 (Move tests)
 - rust-lang#105569 (`bug!` with a better error message for failing `Instance::resolve`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5877a3f into rust-lang:master Dec 12, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 12, 2022
@compiler-errors compiler-errors deleted the resolve-bug-better branch August 11, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants