Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ELF-TLS on SGX #105604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use ELF-TLS on SGX #105604

wants to merge 1 commit into from
+134 −328

Conversation

joboet
Copy link
Member

@joboet joboet commented Dec 12, 2022

fortanix/rust-sgx#419 adds support for thread-local storage to the ELF loader. This allows std to get rid of the key allocation interface so it only needs to manage initializing the TLS section and running destructors on thread exit.

r? @jethrogb
(I totally understand if you don't want this or don't have the time to review. I was just having a bit of fun researching how TLS works 😄.)

@rustbot label +T-libs +O-SGX

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2022

Failed to set assignee to jethrogb: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 12, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added the O-SGX Target: SGX label Dec 12, 2022
@apiraino
Copy link
Contributor

r? libs

@joboet
Copy link
Member Author

joboet commented Jan 17, 2023

@rustbot label +S-blocked
as it depends on fortanix/rust-sgx#419

@rustbot rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 17, 2023
@WaffleLapkin WaffleLapkin removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2023
@bors
Copy link
Contributor

bors commented Aug 24, 2023

☔ The latest upstream changes (presumably #106511) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Nov 8, 2023

☔ The latest upstream changes (presumably #117716) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
O-SGX Target: SGX S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joboet @rustbot @apiraino @bors @m-ou-se @WaffleLapkin