Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove most uses of &fn() from the tests. #10572

Closed
wants to merge 3 commits into from

Conversation

pcwalton
Copy link
Contributor

@alexcrichton
Copy link
Member

Just want to make sure, but 'a || isn't supposed to be valid syntax, right? It's supposed to be ||:'a ?

If so, how hard would it be to add that in this commit as well?

@pcwalton
Copy link
Contributor Author

We need a snapshot to fully make the change. I'd rather do it in a separate commit since it may be a little hairy (requires intermixing trait and region bounds).

@alexcrichton
Copy link
Member

Closing in favor of #10581

flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 11, 2023
Clear with drain

Fixes rust-lang#10572: both the original intent of the issue (extending `clear_with_drain`) and the false negative for `collection_is_never_read` I found in the process are fixed by this PR.

changelog: [`clear_with_drain`]: extend to 5 other types of containers. [`collection_is_never_read`]: fix false negative for `String`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants