Add long error docs for E0460 and E0457
#105860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in diagnostic error codes |
jruderman
reviewed
Dec 18, 2022
jruderman
reviewed
Dec 18, 2022
Ezrashaw
force-pushed
the
add-long-errors-0460-0457
branch
from
f0900bb
to
540c3f4
Compare
|
Done. Thanks for feedback (my punctuation is terrible lol). Also, because I'm newish to rust-lang/rust devoplement, could you explain what's happening with #105791? It hasn't got |
|
That confused me at first too. It's not in a rollup itself, but mentioned in a PR that is included in the rollup. |
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
GuillaumeGomez
approved these changes
Dec 19, 2022
|
Thanks to both of you! @bors r=jruderman,GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
100 tasks
|
Part of #61137 (if you could link to it if you add other error explanations, it'd be awesome!). |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 19, 2022
…, r=jruderman,GuillaumeGomez Add long error docs for `E0460` and `E0457` Final docs for errors in rust-lang#61137 that have UI tests, my next PRs will also add these tests. r? `@GuillaumeGomez`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#105801 (Realistic `Path::as_mut_os_str` doctest) - rust-lang#105860 (Add long error docs for `E0460` and `E0457`) - rust-lang#105895 (Test that we don't add a new kind of breaking change with TAITs) - rust-lang#105902 (docs: improve pin docs) - rust-lang#105910 (Update books) - rust-lang#105913 (rustdoc: remove width-limiter from source pages, stop overriding CSS) - rust-lang#105915 (Revert "Replace usage of `ResumeTy` in async lowering with `Context`") Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final docs for errors in #61137 that have UI tests, my next PRs will also add these tests.
r? @GuillaumeGomez