Fix `uninlined_format_args` in compiler crates with the diagnostic migration completed #105890

Noratrieb · 2022-12-19T08:13:36Z

Convert all the crates that have had their diagnostic migration completed (except save_analysis because that will be deleted soon and apfloat because of the licensing problem).

Some of them have been reviewed by myself and they were all correct (though I still recommend going over all of them again for review).

rustbot · 2022-12-19T08:13:44Z

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

Noratrieb · 2022-12-19T08:31:42Z

compiler/rustc_codegen_llvm/src/llvm_util.rs

@@ -327,11 +327,11 @@ fn print_target_features(sess: &Session, tm: &llvm::TargetMachine) {

    println!("Features supported by rustc for this target:");
    for (feature, desc) in &rustc_target_features {
-        println!("    {1:0$} - {2}.", max_feature_len, feature, desc);
+        println!("    {feature:max_feature_len$} - {desc}.");


That's a fun one, you rarely see it. Looks correct though.

Noratrieb · 2022-12-19T08:38:01Z

(OUTDATED)
~~I looked through all the changes and they look fine, as expected.~~

One problem with this is that this will probably cause a bunch of conflicts with diagnostic migrations which is pretty bad. I'm not sure what the best way to proceed is here. Maybe it makes sense to only do the change on crates that have their diagnostics fully migrated?

~~That does sound like a decent idea to me, I'll do it.~~

rustbot · 2022-12-19T08:38:05Z

Changes rustc_apfloat. rustc_apfloat is currently in limbo and you almost certainly don't want to change it (see #55993).

cc @eddyb

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

matthiaskrgr · 2022-12-19T09:17:32Z

There are some problems regarding refactorings with RA and inline args, which lead clippy to consider disabling the lint by default.
Not sure if you want to land this right now

https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/.60uninlined_format_args.60.20category

rustbot · 2022-12-19T09:39:16Z

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

These commits modify compiler targets.
(See the Target Tier Policy.)

Noratrieb · 2022-12-19T09:41:16Z

As a user for rust-analyzer, the problems aren't bad enough to not do this now in my opinion, but I could also understand it if we deem it bad enough and want to delay it.

bors · 2022-12-20T11:21:23Z

☔ The latest upstream changes (presumably #105880) made this pull request unmergeable. Please resolve the merge conflicts.

RalfJung · 2022-12-20T21:43:11Z

I don't understand why the bot pinged me, I see no interpreter changes?

Noratrieb · 2022-12-21T05:16:25Z

I had some at first that I then removed.

jackh726 · 2023-01-04T22:39:10Z

r=me after rebase

@bors delegate+

bors · 2023-01-04T22:39:12Z

✌️ @Nilstrieb can now approve this pull request

Convert all the crates that have had their diagnostic migration completed (except save_analysis because that will be deleted soon and apfloat because of the licensing problem).

Noratrieb · 2023-01-05T19:14:42Z

@bors r=jackh726

Btw, I have bors permissions already, no need to delegate :D

bors · 2023-01-05T19:14:44Z

📌 Commit fd7a159 has been approved by jackh726

It is now in the queue for this repository.

bors · 2023-01-06T02:58:43Z

⌛ Testing commit fd7a159 with merge 0853d96...

bors · 2023-01-06T06:05:34Z

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 0853d96 to master...

rust-timer · 2023-01-06T07:25:15Z

Finished benchmarking commit (0853d96): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

rustbot assigned jackh726 Dec 19, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2022

Noratrieb commented Dec 19, 2022

View reviewed changes

Noratrieb marked this pull request as ready for review December 19, 2022 08:38

Noratrieb marked this pull request as draft December 19, 2022 09:22

Noratrieb force-pushed the inline-fmt-part-1 branch from d18bde5 to 518f876 Compare December 19, 2022 09:36

rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Dec 19, 2022

Noratrieb changed the title ~~Fix uninlined_format_args in rustc_(a|b|c)* crates~~ Fix uninlined_format_args in compiler crates with the diagnostic migration completed Dec 19, 2022

Noratrieb marked this pull request as ready for review December 19, 2022 09:39

Noratrieb force-pushed the inline-fmt-part-1 branch from 518f876 to fff49f6 Compare December 19, 2022 09:41

Noratrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2023

Fix uninlined_format_args for some compiler crates

fd7a159

Convert all the crates that have had their diagnostic migration completed (except save_analysis because that will be deleted soon and apfloat because of the licensing problem).

Noratrieb force-pushed the inline-fmt-part-1 branch from fff49f6 to fd7a159 Compare January 5, 2023 18:02

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 5, 2023

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 5, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 6, 2023

bors merged commit 0853d96 into rust-lang:master Jan 6, 2023

rustbot added this to the 1.68.0 milestone Jan 6, 2023

Noratrieb deleted the inline-fmt-part-1 branch January 6, 2023 06:11

bors mentioned this pull request Jan 6, 2023

Add simple markdown formatting to rustc --explain output #104540

Closed

3 tasks

Noratrieb mentioned this pull request Jul 28, 2023

inline format!() args #114019

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `uninlined_format_args` in compiler crates with the diagnostic migration completed #105890

Fix `uninlined_format_args` in compiler crates with the diagnostic migration completed #105890

Noratrieb commented Dec 19, 2022 •

edited

Loading

rustbot commented Dec 19, 2022

Noratrieb Dec 19, 2022

Noratrieb commented Dec 19, 2022 •

edited

Loading

rustbot commented Dec 19, 2022

matthiaskrgr commented Dec 19, 2022

rustbot commented Dec 19, 2022

Noratrieb commented Dec 19, 2022

bors commented Dec 20, 2022

RalfJung commented Dec 20, 2022

Noratrieb commented Dec 21, 2022

jackh726 commented Jan 4, 2023

bors commented Jan 4, 2023

Noratrieb commented Jan 5, 2023

bors commented Jan 5, 2023

bors commented Jan 6, 2023

bors commented Jan 6, 2023

rust-timer commented Jan 6, 2023

Fix uninlined_format_args in compiler crates with the diagnostic migration completed #105890

Fix uninlined_format_args in compiler crates with the diagnostic migration completed #105890

Conversation

Noratrieb commented Dec 19, 2022 • edited Loading

rustbot commented Dec 19, 2022

Noratrieb Dec 19, 2022

Choose a reason for hiding this comment

Noratrieb commented Dec 19, 2022 • edited Loading

rustbot commented Dec 19, 2022

matthiaskrgr commented Dec 19, 2022

rustbot commented Dec 19, 2022

Noratrieb commented Dec 19, 2022

bors commented Dec 20, 2022

RalfJung commented Dec 20, 2022

Noratrieb commented Dec 21, 2022

jackh726 commented Jan 4, 2023

bors commented Jan 4, 2023

Noratrieb commented Jan 5, 2023

bors commented Jan 5, 2023

bors commented Jan 6, 2023

bors commented Jan 6, 2023

rust-timer commented Jan 6, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Fix `uninlined_format_args` in compiler crates with the diagnostic migration completed #105890

Fix `uninlined_format_args` in compiler crates with the diagnostic migration completed #105890

Noratrieb commented Dec 19, 2022 •

edited

Loading

Noratrieb commented Dec 19, 2022 •

edited

Loading