Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readable rustdoc display for tvOS and watchOS #105933

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Add readable rustdoc display for tvOS and watchOS #105933

merged 1 commit into from
Dec 20, 2022

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Dec 20, 2022

They are currently displayed as target_os="..." in rustdoc, but it would be nice to have readable display like in iOS and other OSs.

cfg

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2022

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 20, 2022
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 20, 2022

📌 Commit 1b11ce2 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2022
@bors
Auto merge of rust-lang#105940 - matthiaskrgr:rollup-ho4po1t, r=matth…
8a746f4 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#105901 (Don't panic on stable since miri is not available there)
 - rust-lang#105912 (rustdoc: force pre tags to have the default line height)
 - rust-lang#105914 (rustdoc: Simplify CSS for scraped code examples code blocks)
 - rust-lang#105933 (Add readable rustdoc display for tvOS and watchOS)
 - rust-lang#105935 (docs/test: add UI test and long-form error docs for `E0377`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9888ef7 into rust-lang:master Dec 20, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 20, 2022
@taiki-e taiki-e deleted the doc-cfg branch December 20, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@taiki-e @rustbot @GuillaumeGomez @bors