Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some ref patterns from the compiler #106090

Merged
merged 12 commits into from
Jan 20, 2023
Merged

Remove some ref patterns from the compiler #106090

merged 12 commits into from
Jan 20, 2023

Commits on Jan 17, 2023

  1. rustc_const_eval: remove ref patterns (+some pattern matching imps)

    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    3dca58e View commit details
    Browse the repository at this point in the history

  2. rustc_data_structures: remove ref patterns and other artifacts of… 

    … the past
    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    fc6cda8 View commit details
    Browse the repository at this point in the history

  3. rustc_expand: remove ref patterns

    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    bddbf38 View commit details
    Browse the repository at this point in the history

  4. Don't call closures immediately, use try{} blocks

    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    360e978 View commit details
    Browse the repository at this point in the history

  5. rustc_hir_analysis: some general code improvements

    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    d60e772 View commit details
    Browse the repository at this point in the history

  6. rustc_hir_analysis: remove ref patterns

    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    09485ea View commit details
    Browse the repository at this point in the history

  7. tidy 

    rustfmt, pleaaaaase, start supporting rust

Co-authored-by: nils <48135649+Nilstrieb@users.noreply.github.com>
    @WaffleLapkin @Noratrieb
    WaffleLapkin and Noratrieb committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    66751ea View commit details
    Browse the repository at this point in the history

  8. Undo questionable changes

    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    98f30e8 View commit details
    Browse the repository at this point in the history

  9. Review suggestions

    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    8d3c90a View commit details
    Browse the repository at this point in the history

  10. Self review suggestions 

    - add back accidentally removed new lines
- try to deref in patterns, rather than in expressions
  (maybe this was the reason of perf regression?...)
    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c21b1f7 View commit details
    Browse the repository at this point in the history

  11. Untouch back perf sensetive code 😅

    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    4a6d9de View commit details
    Browse the repository at this point in the history

  12. Hack compiletest to fix a random CI failure

    @WaffleLapkin
    WaffleLapkin committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    65d1e8d View commit details
    Browse the repository at this point in the history